SwiftDocCUtilitiesTests: adjust TestFileSystem's handling of paths
#655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When constructing a `URL` with a file path, we should always use `init(fileURLWithPath:)` as not all paths are represented as a URL and require additional encoding. On Windows, this would result in us stripping the drive prefix (`C:`) which would corrupt the path and thus fail to lookup the item. In the second instance, this allowed us to simply avoid an object copy entirely. This helps improve the test pass rate significantly on Windows.
|
@swift-ci please test |
d-ronnqvist
approved these changes
Jul 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When constructing a
URLwith a file path, we should always useinit(fileURLWithPath:)as not all paths are represented as a URL and require additional encoding. On Windows, this would result in us stripping the drive prefix (C:) which would corrupt the path and thus fail to lookup the item. In the second instance, this allowed us to simply avoid an object copy entirely.This helps improve the test pass rate significantly on Windows.