Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[5.9] keep the original URL when decoding Download/ExternalLocationReference #622

Merged
merged 3 commits into from
Jun 14, 2023
Merged

[5.9] keep the original URL when decoding Download/ExternalLocationReference #622

merged 3 commits into from
Jun 14, 2023

Conversation

QuietMisdreavus
Copy link
Contributor

Cherry-pick of #621

  • Explanation: This PR updates DownloadReference and ExternalLocationReference to always keep a decoded URL instead of using their default processing.
  • Scope: Affects systems which post-process Render JSON to include URLs other than what DocC originally generated.
  • GitHub Issue: rdar://110536969
  • Risk: Low. This change does not affect normal documentation generation, and only changes the behavior when the Render JSON data types are used after the fact to load and re-encode Render JSON data.
  • Testing: New tests have been added to verify the new behavior.
  • Reviewer: @ethan-kusters

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus
Copy link
Contributor Author

@swift-ci Please test

@QuietMisdreavus QuietMisdreavus merged commit f7f3564 into swiftlang:release/5.9 Jun 14, 2023
@QuietMisdreavus QuietMisdreavus deleted the 5.9/reference-url-verbatim branch June 14, 2023 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@franklinsch franklinsch franklinsch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@QuietMisdreavus @franklinsch