Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Package.resolved syncing issue with Package.swift #612

Merged
merged 1 commit into from
Jun 7, 2023

Conversation

Kyle-Ye
Copy link
Contributor

@Kyle-Ye Kyle-Ye commented Jun 7, 2023

Bug/issue #, if applicable:

Summary

A follow-up PR for #607

The original PR only updates Package.swift and does not update the corresponding Package.resolved file.

It will cause a git diff every time we open the package locally.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • Added tests
  • Ran the ./bin/test script and it succeeded
  • Updated documentation if necessary

@Kyle-Ye Kyle-Ye requested a review from compnerd June 7, 2023 13:34
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jun 7, 2023

@swift-ci please test

@Kyle-Ye Kyle-Ye force-pushed the optimize/kyle/plugin_version branch from f9ef341 to db9c527 Compare June 7, 2023 14:06
@Kyle-Ye
Copy link
Contributor Author

Kyle-Ye commented Jun 7, 2023

@swift-ci please test

@Kyle-Ye Kyle-Ye requested a review from franklinsch June 7, 2023 14:06
Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry!

@Kyle-Ye Kyle-Ye merged commit 3808cd6 into swiftlang:main Jun 7, 2023
@Kyle-Ye Kyle-Ye deleted the optimize/kyle/plugin_version branch June 7, 2023 17:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants