Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test that took seconds to type check #547

Merged
merged 3 commits into from
Apr 13, 2023

Conversation

d-ronnqvist
Copy link
Contributor

@d-ronnqvist d-ronnqvist commented Apr 12, 2023

Bug/issue #, if applicable: rdar://107960794

Summary

This fixes an issue where one expression in a test was very slow to type check. It also opts in to a warning in debug builds if expressions take too long to type check.

Dependencies

None.

Testing

Run swift test. There shouldn't be warnings about a test taking seconds to type check.

Checklist

Make sure you check off the following items. If they cannot be completed, provide a reason.

  • [ ] Added tests
  • Ran the ./bin/test script and it succeeded
  • [ ] Updated documentation if necessary

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 714d523 into swiftlang:main Apr 13, 2023
@d-ronnqvist d-ronnqvist deleted the slow-type-check-in-test branch April 13, 2023 18:00
d-ronnqvist added a commit to d-ronnqvist/swift-docc that referenced this pull request Apr 13, 2023
* Warn about expressions that take long to type check in debug builds

* Fix slow type checking in test

rdar://107960794
d-ronnqvist added a commit that referenced this pull request Apr 14, 2023
* Warn about expressions that take long to type check in debug builds

* Fix slow type checking in test

rdar://107960794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants