Introduce Cmake support for SwiftCorelibsFoundation #4959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iCharlesHu
force-pushed
the
charles/cmake-support
branch
2 times, most recently
from
57a0715 to
00cdb9e
Compare
parkera
reviewed
May 30, 2024
iCharlesHu
force-pushed
the
charles/cmake-support
branch
from
4521462 to
6e89a05
Compare
iCharlesHu
force-pushed
the
charles/cmake-support
branch
from
1aaa96a to
8a542c6
Compare
jmschonfeld
reviewed
Jun 12, 2024
iCharlesHu
commented
Jun 14, 2024
iCharlesHu
commented
Jun 14, 2024
etcwilde
reviewed
Jun 14, 2024
| PUBLIC | ||
| include | ||
| PRIVATE | ||
| ../CoreFoundation/internalInclude |
There was a problem hiding this comment.
This include path smells a bit funny though.
jmschonfeld
approved these changes
Jun 17, 2024
etcwilde
reviewed
Jun 17, 2024
This was referenced Jun 17, 2024
etcwilde
reviewed
Jun 18, 2024
|
Merging now to reduce the amount of merge conflicts. We will address any additional comments in followup pushes. |
iCharlesHu
force-pushed
the
charles/cmake-support
branch
from
e8cbdec to
c772413
Compare
|
@iCharlesHu is the package branch going to become 'main'? what's the eta for that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch introduces Cmake support for SwiftCorelibFoundation