Never return error for diagnostics request #981
Conversation
|
@swift-ci Please test |
| // VS Code does not request diagnostics again for a document if the diagnostics request failed. | ||
| // Since sourcekit-lsp usually recovers from failures (e.g. after sourcekitd crashes), this is undesirable. | ||
| // Instead of returning an error, return empty results. |
There was a problem hiding this comment.
Is this a VS Code thing or an extension thing? Because IMO it's useful to distinguish between having results and not (consider eg. deciding whether to replace previous issues or not).
There was a problem hiding this comment.
AFAIK it’s a VS Code thing. @adam-fowler to confirm.
There was a problem hiding this comment.
This is a VSCode thing. The extension doesn't have control over when VSCode asks for diagnostics.
Out of interest the "failed" diagnostics request, does that mean no response was returned or that an error response was returned.
There was a problem hiding this comment.
By “failed” I meant an error response. The workaround for this issue is to always return empty diagnostics instead whenever we previously returned an error response.
VS Code does not request diagnostics again for a document if the diagnostics request failed. Since sourcekit-lsp usually recovers from failures (e.g. after sourcekitd crashes), this is undesirable. Instead of returning an error, return empty results.
ahoppen
force-pushed
the
ahoppen/never-error-for-diagnostics-request
branch
from
32cb77f to
4c8aea2
Compare
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
VS Code does not request diagnostics again for a document if the diagnostics request failed. Since sourcekit-lsp usually recovers from failures (e.g. after sourcekitd crashes), this is undesirable. Instead of returning an error, return empty results.