Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show a progress indicator in the editor if SourceKit-LSP is reloading packages #791

Merged
merged 1 commit into from
Aug 30, 2023
Merged

Show a progress indicator in the editor if SourceKit-LSP is reloading packages #791

merged 1 commit into from
Aug 30, 2023

Conversation

ahoppen
Copy link
Member

@ahoppen ahoppen commented Aug 4, 2023

This re-lands #767 after it got reverted. The toolchain build failure should be fixed by adding a check if the client supports work done progress.

guard capabilityRegistry.clientCapabilities.window?.workDoneProgress ?? false else {
  // Client doesn’t support work done progress
  return
}

I noticed that the initial package loading can take ~5s. It’s good behavior to inform the client that sourcekit-lsp is busy reloading the package, showing the user that semantic functionality might not be ready yet.

#620
rdar://112498447

@ahoppen
Show a progress indicator in the editor if SourceKit-LSP is reloading…
7604a1d 
… packages

I noticed that the initial package loading can take ~5s. It’s good behavior to inform the client that sourcekit-lsp is busy reloading the package, showing the user that semantic functionality might not be ready yet.

swiftlang#620
rdar://112498447
@ahoppen ahoppen requested a review from bnbarham August 4, 2023 01:28
@ahoppen ahoppen requested a review from benlangmuir as a code owner August 4, 2023 01:28
@ahoppen
Copy link
Member Author

ahoppen commented Aug 4, 2023

@swift-ci Please test

@ahoppen ahoppen mentioned this pull request Aug 4, 2023
Draft
@ahoppen
Copy link
Member Author

ahoppen commented Aug 29, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit e9697d4 into swiftlang:main Aug 30, 2023
@zacharytamas zacharytamas mentioned this pull request Sep 15, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnbarham bnbarham bnbarham approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahoppen @bnbarham