-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding some documentation on setting up LSP for neovim 0.8+ #783
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The indentation looks maybe a bit excessive (though personal opinion), the code snippet themselves look fine. Maybe add a few links to documentations on the tools so that folks can configure the server for themselves.
e.g https://neovim.io/doc/user/lsp.html#lsp-config, https://neovim.io/doc/user/lsp.html, etc...
I adjusted the indentation to line up with what I see in the rest of the doc (2 spaces), hopefully that will be more consistent. Also added a link to neovim's LSP configuration page for further information. There are some plugins that (theoretically) smooth this out, but since I haven't used them, I'm somewhat reluctant to even tangentially endorse them in the docs. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for making those changes.
There are some plugins that (theoretically) smooth this out, but since I haven't used them, I'm somewhat reluctant to even tangentially endorse them in the docs.
I've been pretty happy with vim-lsp
, though that's listed above. It works reasonably well with neovim too. I haven't tried any of the neovim/lua specific versions either.
Editors/README.md
Outdated
|
||
```lua | ||
require'lspconfig'.sourcekit.setup{ | ||
cmd = {'$TOOLCHAIN_PATH/usr/bin/sourcekit-lsp'} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One more to adjust the indentation on. :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops! my bad! fixed :)
@swift-ci please test |
Windows failure:
|
@swift-ci please test Windows |
@swift-ci Please test Windows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding the documentation @scottfines. That will surely make it easier for people to get started with sourcekit-lsp + neovim 👍🏽
Just my 5 cents. After testing with different setups the most easiest one and less requiring does work perfectly with Neovim :) |
Should be a minor change to the Editors README on how to set up sourcekit-lsp for nevim 0.8 and above. The code segments are taken from my own tested configuration, along with as much notation as I could be reasonably confident in.