Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Port incremental parse ability to sourcekit-lsp #761

Merged
merged 1 commit into from
Jul 14, 2023
Merged

Port incremental parse ability to sourcekit-lsp #761

merged 1 commit into from
Jul 14, 2023

Conversation

StevenWong12
Copy link
Contributor

@StevenWong12 StevenWong12 commented Jul 3, 2023 •
edited
Loading

To sync changes in swiftlang/swift-syntax#1685

This feature will be used when we call changeDocument in SwiftLanguageServer.

TODO:

  • Add test cases for it

@StevenWong12 StevenWong12 force-pushed the enable_incremental_parse branch 2 times, most recently from c9ee1c2 to 230c03e Compare July 5, 2023 14:25
@StevenWong12 StevenWong12 force-pushed the enable_incremental_parse branch from 230c03e to 139a608 Compare July 11, 2023 05:55
ahoppen
ahoppen reviewed Jul 11, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just some minor comments.

@StevenWong12 StevenWong12 force-pushed the enable_incremental_parse branch 2 times, most recently from 81eb8f0 to adbbb3e Compare July 12, 2023 08:44
@StevenWong12 StevenWong12 force-pushed the enable_incremental_parse branch from adbbb3e to c36c5ba Compare July 13, 2023 15:48
@StevenWong12 StevenWong12 marked this pull request as ready for review July 14, 2023 02:38
@StevenWong12
Make sourcekit-lsp parse swift source files incrementally
f1d182e 
This feature will be used when we call `changeDocument` in SwiftLanguageServer
@StevenWong12 StevenWong12 force-pushed the enable_incremental_parse branch from c36c5ba to f1d182e Compare July 14, 2023 06:41
ahoppen
ahoppen approved these changes Jul 14, 2023
View reviewed changes
Copy link
Member

@ahoppen ahoppen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Looking good

@ahoppen
Copy link
Member

ahoppen commented Jul 14, 2023

@swift-ci Please test

@ahoppen ahoppen merged commit ab289aa into swiftlang:main Jul 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahoppen ahoppen ahoppen approved these changes

@benlangmuir benlangmuir Awaiting requested review from benlangmuir

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@StevenWong12 @ahoppen