Update tests to allow multiple -F options #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updates tests to allow compile arguments with multiple -F options such as -F <foo> -Xcc -F -Xcc <foo>. This change is required to support spm changes which forward c compiler flags to the swift compiler in more cases.
|
@swift-ci please test |
MaxDesiatov
approved these changes
May 2, 2023
benlangmuir
approved these changes
May 2, 2023
ahoppen
reviewed
May 2, 2023
| @@ -609,6 +609,7 @@ private func checkNot( | |||
| private func check( | |||
| _ pattern: String..., | |||
| arguments: [String], | |||
| once: Bool = true, | |||
There was a problem hiding this comment.
I would call this allowMultiple. Seems clearer to me.
|
@swift-ci please test |
|
@swift-ci please test |
ahoppen
approved these changes
May 2, 2023
|
@swift-ci Please test Windows |
3 similar comments
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
|
@swift-ci Please test Windows |
MaxDesiatov
pushed a commit
that referenced
this pull request
Jul 19, 2023
- Updates tests to allow compile arguments with multiple -F options such as -F <foo> -Xcc -F -Xcc <foo>. This change is required to support spm changes which forward c compiler flags to the swift compiler in more cases.
MaxDesiatov
added a commit
that referenced
this pull request
Jul 19, 2023
Cherry-pick of #742 required to unblock swiftlang/swift-package-manager#6709. Updates tests to allow compile arguments with multiple `-F` options such as `-F <foo> -Xcc -F -Xcc <foo>`. This change is required to support SwiftPM changes which forward C compiler flags to the Swift compiler in more cases. Co-authored-by: Rauhul Varma <rauhul@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates tests to allow compile arguments with multiple
-Foptions such as-F <foo> -Xcc -F -Xcc <foo>. This change is required to support SwiftPM changes which forward C compiler flags to the swift compiler in more cases.