Send token with WorkDoneProgress #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxDesiatov
reviewed
Apr 19, 2023
| /// The progress data. | ||
| public var value: WorkDoneProgressType | ||
|
|
||
| public init(token: ProgressToken, value: WorkDoneProgressType) { |
There was a problem hiding this comment.
Is this initializer used anywhere outside of the tests? I don't see any other references to it in this PR.
There was a problem hiding this comment.
No due to #577. I use your type definitions in another language server and want to use $/progress => I implement it and send it upstream
|
@swift-ci test |
ahoppen
reviewed
Apr 20, 2023
Sources/LanguageServerProtocol/Notifications/WorkDoneProgress.swift
Outdated
Show resolved
Hide resolved
|
@swift-ci test |
|
@swift-ci Please test Windows |
ahoppen
approved these changes
Apr 20, 2023
|
Thank you. I don’t know how much you care but if you’d like this to be in the Swift 5.9 release, you will need to create a separate PR for the |
|
Personally it's not that important to have it at any tag, as I just use the main branch from this repo |
|
OK, in that case there’s no reason to cherry-pick it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the $/progress notification, as it requires that the ProgressToken is sent with the value.
swift testworks, theoretically it should probably be calledProgressParams, but it wouldn't reflect that it is a notification, so I just changed the enum toWorkDoneProgressType