This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Achieve Carthage compatibility by compiling source file in target's build phase #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is there any problem to merge? |
|
@tomorrowkey, this is all good to merge from my point of view, but as this repository belongs to @bahlo, he will need to evaluate and merge if he is satisfied with my pull request. |
tforzaglia
changed the title
tanukiti1987
approved these changes
Jun 25, 2018
tomorrowkey
approved these changes
Jun 25, 2018
|
Thank you very much! |
|
@bahlo Thank you 👍 Is there the plan to release new version at CocoaPods and Carthage? |
Closed
|
I had the same problem last week. Everything up to date, I guess: Cartfile: Terminal: The Framework is build but it seams to be empty... as a fix I just use the modulefile source directly. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @bahlo
Great framework here! Very useful for an app I'm working on. I'm using Carthage in my app and was unfortunately having a problem with integrating SwiftGif. Based on #48, it seems that others have also had similar problems with using Carthage to integrate SwiftGif.
Anyway, this PR should fix the issue. Feel free to test it out and merge if you like.