Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update readme instructions & version #164

Merged
merged 6 commits into from
Jan 25, 2024
Merged

Update readme instructions & version #164

merged 6 commits into from
Jan 25, 2024

Conversation

tib
Copy link
Contributor

@tib tib commented Nov 18, 2023

Hello,

I'd like to contribute a small readme update with the following changes:

  • package version is bumped to 2.0.0, since the current version is at 2.3.0
  • target dependency snippet is now a one-liner, so users can simply copy & paste it
  • added an extra code section with a sample Package.swift file, using ServiceLifecycle

Best,
Tib

FranzBusch
FranzBusch reviewed Nov 20, 2023
View reviewed changes
Copy link
Contributor

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this. Do you mind adding this to the index document of our Docc article as well?

README.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
tib and others added 3 commits November 20, 2023 12:49
@tib @FranzBusch
Update README.md
d26d1bb 
Co-authored-by: Franz Busch <privat@franz-busch.de>
@tib @FranzBusch
Update README.md
c7006e2 
Co-authored-by: Franz Busch <privat@franz-busch.de>
@tib
add getting started to docc index
e15ff7f
@tib
Copy link
Contributor Author

tib commented Nov 20, 2023

Thanks for updating this. Do you mind adding this to the index document of our Docc article as well?

I just did that too, using v2.3.0, I hope this is what you were thinking about.

FranzBusch
FranzBusch approved these changes Nov 20, 2023
View reviewed changes
Copy link
Contributor

@FranzBusch FranzBusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for the work!

@FranzBusch
Copy link
Contributor

@swift-server-bot test this please

@FranzBusch FranzBusch enabled auto-merge (squash) November 20, 2023 12:47
@FranzBusch
Copy link
Contributor

@swift-server-bot test this please

@FranzBusch
Copy link
Contributor

@swift-server-bot test this please

@FranzBusch FranzBusch merged commit b21c43a into swift-server:main Jan 25, 2024
4 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FranzBusch FranzBusch FranzBusch approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tib @FranzBusch