Propagate service error when gracefully shutting down #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vlm
reviewed
Aug 22, 2023
vlm
reviewed
Aug 22, 2023
| @@ -338,6 +338,7 @@ public actor ServiceGroup: Sendable { | |||
| group: &group, | |||
| gracefulShutdownManagers: gracefulShutdownManagers | |||
| ) | |||
| return .failure(error) | |||
| } catch { | |||
| return .failure(error) | |||
There was a problem hiding this comment.
Yes this is the error if the group fails to shutdown. What do you expect here? The error from the original service that threw or the error during shutdown?
There was a problem hiding this comment.
I would expect the original service error. Basically, the first service that fails. Makes debugging easier, because cleanup code is frequently buggy so benign errors are likely going to be masked by broken shutdown code elsewhere if we do use the last error.
There was a problem hiding this comment.
Agreed. We are also logging that another service threw during shutdown and what error it threw.
vlm
approved these changes
Aug 22, 2023
# Motivation Propagate the service error when we shutdown the group after the service threw.
FranzBusch
force-pushed
the
fb-fix-throw-gracefulshutdown
branch
from
efff8de to
6e92f03
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Propagate the service error when we shutdown the group after the service threw.