shutdown() should cancel the signal handlers installed by start() #120
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@oc243 ptal if this is what you needed |
motivation: allow easier testing of shutdown hooks changes: * introduce ServiceLifecycle.removeTrap which removes a trap * call ServiceLifecycle.removeTrap when setting up the shutdown hook * make the shutdown hook cleanup into a lifecycle task to ensure correct ordering * add tests * improve logging rdar://89552798
yim-lee
approved these changes
May 17, 2022
Co-authored-by: Yim Lee <yim_lee@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
motivation: allow easier testing of shutdown hooks
changes:
rdar://89552798