Add fix and test for MetricsSystem.prometheus() #49
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ktoso
approved these changes
May 4, 2021
| func testGetPrometheus() { | ||
| MetricsSystem.bootstrapInternal(NOOPMetricsHandler.instance) | ||
| XCTAssertThrowsError(try MetricsSystem.prometheus()) | ||
| MetricsSystem.bootstrapInternal(PrometheusMetricsFactory(client: self.prom)) |
There was a problem hiding this comment.
Not sure I love that style but I guess this was introduced some time recently for some reason?
There was a problem hiding this comment.
I see, so it's for the configs etc. Thanks for the pointer; perhaps we can sugar the configuration-less case to just bootstrap with prometheus client as parameter but that's minor...
Thanks for the pointer :)
There was a problem hiding this comment.
No problem. And definitely open to add sugar here 👍🏻
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #48
SwiftPrometheus 1.0.0 Alpha 10 introduced a bug where
MetricsSystem.prometheus()would no longer work, since it looks for aPrometheusClientinstance, but since Alpha 10 it's a wrapper struct.Introduced new with this PR is a
PrometheusWrappedMetricsFactoryprotocol that should be used by anyMetricsFactorywrappingPrometheusClientin any way.MetricsSystem.prometheus()will now look for aPrometheusWrappedMetricsFactoryand return the underlyingclientChecklist