Skip to content

Conversation

jordanebelanger
Copy link
Contributor

The Vapor 4 metrics endpoint example leads to a leaked promise error when running it in debug mode. Consider the following instead.

Fix Vapor 4 metrics endpoint example leading to an NIO leaky promise error at runtime in debug mode.
Copy link
Collaborator

@MrLotU MrLotU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks 👍

@MrLotU MrLotU merged commit db5bb3d into swift-server:master Nov 18, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants