Fix RELEASE.md included in package build #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes the following warning when using this package as a dependency in another swift project, specifically when running `swift build` warning: 'swift-prometheus': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target
incertum
reviewed
Sep 26, 2025
There was a problem hiding this comment.
Thank you, and yes let's address the warning message.
Run
curl -s --retry 3 https://raw.githubusercontent.com/swiftlang/github-workflows/refs/heads/main/.github/workflows/scripts/check-swift-format.sh | bash
locally and then re-push to fix the formatting failure. (I'll improve the contributing docs asap.)
The other failure seems a perf improvement on current nightly-main, we'll check.
=== BEGIN DIFF ===
diff --git a/Benchmarks/Thresholds/nightly-main/PrometheusBenchmarks.DurationHistogram.p90.json b/Benchmarks/Thresholds/nightly-main/PrometheusBenchmarks.DurationHistogram.p90.json
index 282dc64..557fc88 100644
--- a/Benchmarks/Thresholds/nightly-main/PrometheusBenchmarks.DurationHistogram.p90.json
+++ b/Benchmarks/Thresholds/nightly-main/PrometheusBenchmarks.DurationHistogram.p90.json
@@ -1,3 +1,3 @@
{
- "mallocCountTotal" : 2
+ "mallocCountTotal" : 1
}
|
Looks good to me when formatting fixed, thank you! |
ktoso
approved these changes
Oct 3, 2025
Signed-off-by: Melissa Kilby <mkilby@apple.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the following warning when using this package as a dependency in another swift project, specifically when running
swift buildwarning: 'swift-prometheus': found 1 file(s) which are unhandled; explicitly declare them as resources or exclude from the target