-
Notifications
You must be signed in to change notification settings - Fork 114
[core] Implement Lambda streaming with custom HTTP headers #521
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sebsto
wants to merge
2
commits into
swift-server:main
Choose a base branch
from
sebsto:sebsto/streaming+http-headers
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -12,4 +12,5 @@ Package.resolved | |
.vscode | ||
Makefile | ||
.devcontainer | ||
.amazonq | ||
.amazonq | ||
.kiro |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
100 changes: 100 additions & 0 deletions
100
Sources/AWSLambdaRuntime/LambdaResponseStreamWriter+Headers.swift
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,100 @@ | ||
//===----------------------------------------------------------------------===// | ||
// | ||
// This source file is part of the SwiftAWSLambdaRuntime open source project | ||
// | ||
// Copyright (c) 2017-2024 Apple Inc. and the SwiftAWSLambdaRuntime project authors | ||
// Licensed under Apache License v2.0 | ||
// | ||
// See LICENSE.txt for license information | ||
// See CONTRIBUTORS.txt for the list of SwiftAWSLambdaRuntime project authors | ||
// | ||
// SPDX-License-Identifier: Apache-2.0 | ||
// | ||
//===----------------------------------------------------------------------===// | ||
|
||
import NIOCore | ||
|
||
#if canImport(FoundationEssentials) | ||
import FoundationEssentials | ||
#else | ||
import Foundation | ||
#endif | ||
|
||
/// A response structure specifically designed for streaming Lambda responses that contains | ||
/// HTTP status code and headers without body content. | ||
/// | ||
/// This structure is used with `LambdaResponseStreamWriter.writeStatusAndHeaders(_:)` to send | ||
/// HTTP response metadata before streaming the response body. | ||
public struct StreamingLambdaStatusAndHeadersResponse: Codable, Sendable { | ||
/// The HTTP status code for the response (e.g., 200, 404, 500) | ||
public let statusCode: Int | ||
|
||
/// Dictionary of single-value HTTP headers | ||
public let headers: [String: String]? | ||
|
||
/// Dictionary of multi-value HTTP headers (e.g., Set-Cookie headers) | ||
public let multiValueHeaders: [String: [String]]? | ||
|
||
/// Creates a new streaming Lambda response with status code and optional headers | ||
/// | ||
/// - Parameters: | ||
/// - statusCode: The HTTP status code for the response | ||
/// - headers: Optional dictionary of single-value HTTP headers | ||
/// - multiValueHeaders: Optional dictionary of multi-value HTTP headers | ||
public init( | ||
statusCode: Int, | ||
headers: [String: String]? = nil, | ||
multiValueHeaders: [String: [String]]? = nil | ||
) { | ||
self.statusCode = statusCode | ||
self.headers = headers | ||
self.multiValueHeaders = multiValueHeaders | ||
} | ||
} | ||
|
||
extension LambdaResponseStreamWriter { | ||
/// Writes the HTTP status code and headers to the response stream. | ||
/// | ||
/// This method serializes the status and headers as JSON and writes them to the stream, | ||
/// followed by eight null bytes as a separator before the response body. | ||
/// | ||
/// - Parameters: | ||
/// - response: The status and headers response to write | ||
/// - encoder: The encoder to use for serializing the response, | ||
/// - Throws: An error if JSON serialization or writing fails | ||
public func writeStatusAndHeaders<Encoder: LambdaOutputEncoder>( | ||
_ response: StreamingLambdaStatusAndHeadersResponse, | ||
encoder: Encoder | ||
) async throws where Encoder.Output == StreamingLambdaStatusAndHeadersResponse { | ||
|
||
// Convert Data to ByteBuffer | ||
var buffer = ByteBuffer() | ||
try encoder.encode(response, into: &buffer) | ||
|
||
// Write the JSON data | ||
try await write(buffer) | ||
|
||
// Write eight null bytes as separator | ||
var separatorBuffer = ByteBuffer() | ||
separatorBuffer.writeBytes([0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00, 0x00]) | ||
try await write(separatorBuffer) | ||
} | ||
} | ||
|
||
extension LambdaResponseStreamWriter { | ||
/// Writes the HTTP status code and headers to the response stream. | ||
/// | ||
/// This method serializes the status and headers as JSON and writes them to the stream, | ||
/// followed by eight null bytes as a separator before the response body. | ||
/// | ||
/// - Parameters: | ||
/// - response: The status and headers response to write | ||
/// - encoder: The encoder to use for serializing the response, use JSONEncoder by default | ||
/// - Throws: An error if JSON serialization or writing fails | ||
public func writeStatusAndHeaders( | ||
_ response: StreamingLambdaStatusAndHeadersResponse, | ||
encoder: JSONEncoder = JSONEncoder() | ||
) async throws { | ||
try await self.writeStatusAndHeaders(response, encoder: LambdaJSONOutputEncoder(encoder)) | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.