Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make S3 eTag optional #78

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Conversation

jsonfry
Copy link
Contributor

@jsonfry jsonfry commented Nov 28, 2024

Make S3 Object eTag optional, because it's not always there.

Motivation:

I'm seeing real events without an eTag, which naturally is causing decoding failures.

Modifications:

Made S3 Object eTag optional.

Result:

S3 Object eTag is now optional...

@sebsto sebsto self-requested a review December 2, 2024 20:19
@sebsto sebsto self-assigned this Dec 2, 2024
@sebsto sebsto added kind/bug Feature doesn't work as expected. semver/none No version bump required. labels Dec 2, 2024
@sebsto sebsto merged commit 3c1161a into swift-server:main Dec 2, 2024
17 of 19 checks passed
@sebsto
Copy link
Contributor

sebsto commented Dec 2, 2024

Thank you @jsonfry for having submitted this
Merged now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Feature doesn't work as expected. semver/none No version bump required.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants