Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix documentation errors #24

Merged
merged 6 commits into from
Jan 9, 2025
Merged

Conversation

tayloraswift
Copy link
Collaborator

@tayloraswift tayloraswift commented Jan 9, 2025

this PR corrects all of the CI errors resulting from broken links in this repo, and also purges all DocC symbol hashes and replaces them with new type signature based disambiguators.

the CI is still failing because setenv(_:_:_:) doesn’t exist as a function on macOS (it is a stdlib builtin). however, it exists on Linux, and should work on Swiftinit.

Copy link
Contributor

@tib tib left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 😉

Can we fix the setenv related issue in the macOS build somehow?

@Joannis
Copy link
Member

Joannis commented Jan 9, 2025

Much nicer!

@Joannis Joannis merged commit 5b98959 into swift-on-server:main Jan 9, 2025
1 of 2 checks passed
@tayloraswift
Copy link
Collaborator Author

Looks good to me. 😉

Can we fix the setenv related issue in the macOS build somehow?

this is just a platform difference between NIOPosix on Linux and NIOPosix on Darwin. our options are:

  1. remove macOS doc build, and just have Ubuntu 24.04 (on which NIOPosix has that symbol), or
  2. remove that link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants