Skip to content

Commit

Permalink
Fix agent default config override template (open-telemetry#25)
Browse files Browse the repository at this point in the history
move `exporters` and `service.pipelines` into if statement to avoid
setting them to null when standalone is disabled

Signed-off-by: naseemkullah <naseem@transit.app>
  • Loading branch information
Naseem authored Jan 27, 2021
1 parent ff5b5a0 commit 609d9ee
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 5 deletions.
2 changes: 1 addition & 1 deletion charts/opentelemetry-collector/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-collector
version: 0.3.0
version: 0.3.1
description: OpenTelemetry Collector Helm chart for Kubernetes
type: application
home: https://opentelemetry.io/
Expand Down
8 changes: 4 additions & 4 deletions charts/opentelemetry-collector/templates/_config.tpl
Original file line number Diff line number Diff line change
Expand Up @@ -105,19 +105,19 @@ Get otel memory_limiter ballast_size_mib value based on 40% of resources.memory.
Default config override for agent collector deamonset
*/}}
{{- define "opentelemetry-collector.agentConfigOverride" -}}
{{- if .Values.standaloneCollector.enabled }}
exporters:
{{- if .Values.standaloneCollector.enabled }}
otlp:
endpoint: {{ include "opentelemetry-collector.fullname" . }}:55680
insecure: true
{{- end }}
{{- end }}

{{- if .Values.standaloneCollector.enabled }}
service:
pipelines:
{{- if .Values.standaloneCollector.enabled }}
metrics:
exporters: [otlp]
traces:
exporters: [otlp]
{{- end }}
{{- end }}
{{- end }}

0 comments on commit 609d9ee

Please sign in to comment.