Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extract_count_metric OTTL function to transform processor #2449

Conversation

swiatekm
Copy link
Owner

Description:

Link to tracking Issue:

Testing:

Documentation:

@swiatekm swiatekm force-pushed the feat/transformprocessor/histogram-convert branch 2 times, most recently from 7281e3a to b70733b Compare July 26, 2023 09:18
@swiatekm swiatekm force-pushed the feat/transformprocessor/extract_count_metric branch from 5541a86 to e3d7a46 Compare July 26, 2023 10:52
@swiatekm swiatekm force-pushed the feat/transformprocessor/histogram-convert branch 3 times, most recently from 8ebebcc to c4964a6 Compare August 2, 2023 10:27
Frapschen and others added 6 commits August 2, 2023 08:46
…pen-telemetry#24772)

Follows open-telemetry#24688

This is an incremental step towards hardening `fileconsumer` package.
This isolates the "finding files" logic into its own package. The
recently added filtering of files based on additional criteria is left
in place for now. It also strengthens the test cases by using actual
input, which is often relative, instead of converting everything to
absolute paths.
**Description:** <Describe what has changed.>
The conversion from HTTP spans to X-Ray segments did not accurately
capture the HTTP status code during the translation of the cause. As a
result, some failed HTTP requests with 4xx and 5xx status codes were
displayed as having an "OK" status in the X-Ray console. Also, add
remote attribute in Exception for X-Ray remote segments.

**Link to tracking Issue:** <Issue number if applicable>
N/A

**Testing:** <Describe what testing was performed and which tests were
added.>
unit test
**Documentation:** <Describe the documentation added.>
N/A
…pen-telemetry#24740)

**Description:**
Removes the deprecated prometheus_exec receiver. This component was
[deprecated over a year
ago](open-telemetry#9058),
even before our now [documented `two minor
releases`](https://github.com/open-telemetry/opentelemetry-collector#deprecated)
timeline.

**Link to tracking Issue:** <Issue number if applicable>

Related to
open-telemetry#6722

**Testing:**
Confirmed `make otelcontribcol` works
@swiatekm swiatekm force-pushed the feat/transformprocessor/extract_count_metric branch from e3d7a46 to c59d765 Compare August 3, 2023 10:44
atoulme and others added 16 commits August 3, 2023 09:11
…metrics (open-telemetry#24808)

This is a breaking change to mdatagen. With this change we change the
field `aggregation` to `aggregation_temporality` for sum metrics. This
change helps pave the way to setting aggregation settings on metrics.
…r skeleton (open-telemetry#23225)

**Description:**
Add initial commit of receiver component including the github sub
scraper. This receiver is in development and what is included here is
only a skeleton.
**Link to tracking Issue:**  

open-telemetry#22028

**Testing:**

- basic tests were added but as this is in development, it's only a
skeleton.

**Documentation:**

- basic set of documentation was added as part of the skeleton

---------

Co-authored-by: Andrzej Stencel <astencel@sumologic.com>
Co-authored-by: Juraci Paixão Kröhling <juraci.github@kroehling.de>
…ed HTTP headers (open-telemetry#24414)

**Description:** This could be described as a fix or an improvement to
the [jaegerremotesampling
extension](https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/extension/jaegerremotesampling).

Status quo: For usages in which a `remote` source is specified using
collector-wide standard
[configgrpc.GRPCClientSettings](https://github.com/open-telemetry/opentelemetry-collector/blob/b5e511ce31f22fd3d4817236792245fe1bd88ef8/config/configgrpc/configgrpc.go#L54),
the given HTTP headers are not actually set on outbound calls to the
destination `grpcstore.SamplingManager` endpoint.

After this PR: Outbound calls will add any HTTP headers specified in the
gRPC client settings for the remote source. This will mean that drop-in
extension usage will support use cases in which header additions are
necessary for remote interactions. I took an approach that I observed in
several other exporters/extensions: "enhancing" the gRPC context.

**Link to tracking Issue:** N/A

**Testing:** Existing extension integration tests have been updated to
perform a (previously not performed) client-like HTTP call to the
extension's running gRPC server, and then to verify that an observed
call to a gRPC remote includes configured HTTP header additions (as gRPC
metadata).

**Documentation:** N/A: I assumed the behavior that this PR now
implements, because the gRPC client settings config is so "standard"
throughout the opentelemetry-collector repo (and other extensions in
this contrib repo).

---------

Co-authored-by: Antoine Toulme <antoine@toulme.name>
…metry#24368)

**Description:**
Added a function for extracting the sum from a Histogram,
ExponentialHistogram or Summary as an individual metric. The added
function also works for Summaries, so we can later deprecate the
Summary-specific `summary_sum_val_to_sum` function.

**Link to tracking Issue:** open-telemetry#22853 

**Testing:**
Added unit tests both for the function itself and OTTL statements
involving it.

**Documentation:**
Added a section in the README.

---------

Co-authored-by: Evan Bradley <11745660+evan-bradley@users.noreply.github.com>
Unexport constants that were exposed as part of the configuration of the
processor.
…elemetry#24841)

This struct is not part of the official Go API of the component and
therefore doesn't need to be exported.
…etry#24844)

Offer to unexport this function as it is only used in tests.
I could not find how mockery was invoked, so I also removed that those
structs were generated.
…-telemetry#24770)

**Description:**
Migrate from OpenCensus data model to pdata on collectdreceiver. Using
golden to compare metrics for testing.

Since wavefrontreceiver depends on collectdreceiver, adjustments are
necessary in the go.mod and go.sum files.

**Link to tracking Issue:** [20760](open-telemetry#20760)

---------

Co-authored-by: Antoine Toulme <antoine@toulme.name>
)

**Description:** 
Adding a feature - Allow option of adding a required header for incoming
webhook requests. If header doesn't match, returns a 401.

**Link to tracking Issue:**
[<24270>](open-telemetry#24270)
Unexport the `MezmoLogLine` and `MezmoLogBody` structs. They don't need to be exported as part of the Go API.
Dependabot automation cannot handle it due to removed
go.opentelemetry.io/build-tools/internal/check

Same as
open-telemetry/opentelemetry-collector#8173
atoulme and others added 27 commits August 5, 2023 17:47
Make sure to close the http response when performing health checks.
…pen-telemetry#24924)

This allows to manage the initial health check call through the context
being passed in on start.
…ry#24971)

Add example of working MySQL datasource format- took me combing the Go
source code and MySQL docs to figure this out.
…e reassigned next (open-telemetry#24945)

Very simple lint fix found by wastedassign linter.
…emetry#24973)

The exported functions now only used by opencensus receiver and
exporter. It's still makes sense to keep it in the pkg/translator for
consistency with other formats, but deprecation mark isn't needed
anymore.
No context object is available in dimclient, so passing
context.Background() for now.
Component(s):
processor/datadog

The Datadog processor is a component the needs to be deprecated in favor
of the Datadog connector. The migration from one component to the other
will take effect after two minor releases. Therefore, during the
deprecation process, code that is used by the Datadog processor and
connector can be shared instead of duplicated.

[Link to relevant
issue](open-telemetry#19740)

---------

Co-authored-by: Yang Song <songy23@users.noreply.github.com>
…n-telemetry#21629)

**Description:** <Describe what has changed.>
<!--Ex. Fixing a bug - Describe the bug and how this fixes the issue.
Ex. Adding a feature - Explain what this achieves.-->
- Adds new option to disable the batchspanprocessor for testing large
trace sizes (enabled by default)
- Adds new option to configure size in MB of each trace generated for
load testing
- Fixes issue where large trace payloads (>2000) wouldn't generate the
correct number of traces, needed to add delay after each trace is
generated

---------

Co-authored-by: Pablo Baeyens <pbaeyens31+github@gmail.com>
…ctor format (open-telemetry#23649)

**Description:** This PR adds a new marshaller for `awss3` exporter. It
exports logs in the format of Sumo Logic Installed Collector. Metrics
and traces are not supported - creating an exporter for them will result
in an error.
Currently, nested typed (eg. map inside a map) might not be supported
correctly - I have to confirm the IC's behavior with them, but I wanted
to create the PR so that it can be reviewed early.

**Link to tracking Issue:** open-telemetry#23212

**Testing:** Unit tests and manual e2e tests. Some automatic e2e tests
will come later, but they will not be part of this repo, they will be a
test for integrating the ingest with Sumo Logic's backend.

**Documentation:** Readme updated.

---------

Signed-off-by: Katarzyna Kujawa <kkujawa@sumologic.com>
Co-authored-by: Katarzyna Kujawa <kkujawa@sumologic.com>
@swiatekm swiatekm force-pushed the feat/transformprocessor/extract_count_metric branch from e62a98e to 45c39e9 Compare August 7, 2023 10:02
@swiatekm swiatekm closed this Aug 9, 2023
@swiatekm swiatekm deleted the feat/transformprocessor/extract_count_metric branch October 23, 2023 12:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.