Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Decision 8 Documenting quality dimensions" #34

Merged
merged 7 commits into from
Oct 27, 2024

Conversation

BobBorges
Copy link
Contributor

Reverts #31

revert premature merge

@BobBorges BobBorges requested review from MansMeg and ninpnin October 17, 2024 12:32
@BobBorges
Copy link
Contributor Author

I removed the prematurely merged documents from main and reintroduce them here. @MansMeg only minor edits to the decision doc -- templates look fine.

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

Can you edit the paragraph where I now say that the template should be included as a header in the unit test files?

@BobBorges
Copy link
Contributor Author

Can you edit the paragraph where I know say that the template should be included as a header in the unit test files?

So you want it to say what exactly? In python, this would be a docstring, equivalent to a description... you can either import .md, write a docstring, or both... all this ends up in the API documentation.

A short docstring is handy for people who look at the code and not the documentation.

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

Now it says the following:

Each test should be stored as test-[what-is-checked-automatically].py/r. Each test should include a header in comment describing the test and why it has been included. See the data-integrity-test template.

What should it say on how we store the documentation? I guess we should store .md files? Maybe with the name readme-[what-is-checked-automatically].md ?

@BobBorges
Copy link
Contributor Author

I think the quality estimate can also be stored as test-[some-quality-dimension].py. it's also a kind of test.

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

I think there is a difference, and we make a difference in our paper. I also think there is a qualitative difference between the two.
So, I would try to separate them. Say:
qe-[some-quality-dimension].py or similar.

@MansMeg
Copy link
Contributor

MansMeg commented Oct 17, 2024

I think it looks really good now!

@BobBorges
Copy link
Contributor Author

OK, so I changed the status in the document. will merge after @ninpnin's approval.

@BobBorges BobBorges merged commit 224385f into main Oct 27, 2024
@BobBorges BobBorges deleted the revert-31-decision-8 branch October 27, 2024 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants