Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue/52 whitespace before langtag #56

Merged
merged 4 commits into from
Jan 18, 2025

Conversation

Michiel-s
Copy link

Allow whitespace between quoted string literal and langtag or datatype.

Fixes #52

Allow whitespace between quoted string literal and langtag or datatype
@Michiel-s
Copy link
Author

@k00ni, would you be so kind to review this PR?

Please let me know if changes are needed.

@zozlak
Copy link

zozlak commented Jan 13, 2025

As both from the formal perspective (RDFLiteral ::= String (LANGTAG | '^^' iri)? and from your implementation perspective this fix applies both to the lang tag and the datatype IRI, could you please add the test for the datatype IRI as well?

@Michiel-s
Copy link
Author

As both from the formal perspective (RDFLiteral ::= String (LANGTAG | '^^' iri)? and from your implementation perspective this fix applies both to the lang tag and the datatype IRI, could you please add the test for the datatype IRI as well?

Done.

@zozlak
Copy link

zozlak commented Jan 17, 2025

Thank you! I have no further objections but will leave accepting the merge to the @k00ni

@k00ni k00ni added the enhancement New feature or request label Jan 18, 2025
@k00ni k00ni merged commit c573f61 into sweetrdf:master Jan 18, 2025
11 checks passed
@k00ni
Copy link
Member

k00ni commented Jan 18, 2025

Good addition.

@Michiel-s Michiel-s deleted the issue/52-whitespace-before-langtag branch January 18, 2025 19:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Turtle parser error for white space between String and LANGTAG
3 participants