-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable GitHub Actions for pull requests #26
Conversation
That behavior is weird, because for my own pull requests it always started related Github Actions: https://github.com/sweetrdf/easyrdf/pulls?q=is%3Apr+is%3Aclosed These are my settings, never had problems before. Maybe I overlooked something: |
@k00ni They are running now :) |
Haha, thank you @claudiu-cristea! I will check the PHPStan complain and try to upload a fix soon. |
@k00ni will try to fix here |
@k00ni now it doesn't work anymore
|
That is what I expect to see. No problem. I took the liberty and refined your fix. It should be good now. |
Anyway, PHP7 should be removed. It's not supported anymore |
That is correct, but there are still many people using it in production. As long as there is no blocker for fixes or required changes, I would rather keep PHP 7 compatibility in EasyRdf. |
.. also fixes a PHPStan complaint.