Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable GitHub Actions for pull requests #26

Merged
merged 4 commits into from
Mar 23, 2023
Merged

Enable GitHub Actions for pull requests #26

merged 4 commits into from
Mar 23, 2023

Conversation

claudiu-cristea
Copy link

@claudiu-cristea claudiu-cristea commented Mar 23, 2023

.. also fixes a PHPStan complaint.

@k00ni
Copy link
Member

k00ni commented Mar 23, 2023

That behavior is weird, because for my own pull requests it always started related Github Actions: https://github.com/sweetrdf/easyrdf/pulls?q=is%3Apr+is%3Aclosed

These are my settings, never had problems before. Maybe I overlooked something:

Bildschirmfoto von 2023-03-23 14-27-17

@k00ni k00ni added the fix label Mar 23, 2023
@claudiu-cristea
Copy link
Author

@k00ni They are running now :)

@k00ni
Copy link
Member

k00ni commented Mar 23, 2023

Haha, thank you @claudiu-cristea!

I will check the PHPStan complain and try to upload a fix soon.

@claudiu-cristea
Copy link
Author

@k00ni will try to fix here

@claudiu-cristea
Copy link
Author

claudiu-cristea commented Mar 23, 2023

@k00ni now it doesn't work anymore

This workflow requires approval from a maintainer

@k00ni
Copy link
Member

k00ni commented Mar 23, 2023

This workflow requires approval from a maintainer

That is what I expect to see. No problem.

I took the liberty and refined your fix. It should be good now.

@k00ni k00ni changed the title Try to run GitHub Actions Enable GitHub Actions for pull requests Mar 23, 2023
@claudiu-cristea
Copy link
Author

Anyway, PHP7 should be removed. It's not supported anymore

@k00ni k00ni merged commit 29ef4ca into sweetrdf:master Mar 23, 2023
@k00ni
Copy link
Member

k00ni commented Mar 23, 2023

Anyway, PHP7 should be removed. It's not supported anymore

That is correct, but there are still many people using it in production. As long as there is no blocker for fixes or required changes, I would rather keep PHP 7 compatibility in EasyRdf.

@claudiu-cristea claudiu-cristea deleted the github-actions branch March 23, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants