Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add replace-part to composer.json #20

Merged
merged 1 commit into from
Nov 8, 2022
Merged

Conversation

k00ni
Copy link
Member

@k00ni k00ni commented Oct 19, 2022

Fixes #19

@k00ni k00ni added the enhancement New feature or request label Oct 19, 2022
@k00ni k00ni self-assigned this Oct 19, 2022
@claudiu-cristea
Copy link

claudiu-cristea commented Nov 7, 2022

@k00ni, finally, I got the chance to test the PR

In project's composer.json I've added:

"require": {
    . . .
    "sweetrdf/easyrdf": "dev-add-replace-to-composer.json"
}

Then I ran:

$ composer update sweetrdf/easyrdf
Gathering patches for root package.
Loading composer repositories with package information
Updating dependencies
Lock file operations: 1 install, 0 updates, 1 removal
  - Removing easyrdf/easyrdf (1.1.1)
  - Locking sweetrdf/easyrdf (dev-add-replace-to-composer.json 56393bb)
Writing lock file
Installing dependencies from lock file (including require-dev)
Package operations: 1 install, 0 updates, 1 removal
  - Downloading sweetrdf/easyrdf (dev-add-replace-to-composer.json 56393bb)
  - Removing easyrdf/easyrdf (1.1.1)
Gathering patches for root package.
Gathering patches for dependencies. This might take a minute.
  - Installing sweetrdf/easyrdf (dev-add-replace-to-composer.json 56393bb): Extracting archive 

You can see how easyrdf/easyrdf has been removed and sweetrdf/easyrdf added. Note that easyrdf/easyrdf isn't a direct dependency in my project. Instead we depend on drupal/sparql_entity_storage which depends on "easyrdf/easyrdf": "^1.0". So, with this change it's possible to swap out the original package without having it as direct dependency.

IMHO, this is ready to be merged. Thank you.

PS: Can't wait for a release including this fix.

@k00ni k00ni merged commit a93cd6a into master Nov 8, 2022
@k00ni k00ni deleted the add-replace-to-composer.json branch November 8, 2022 08:06
@k00ni
Copy link
Member Author

k00ni commented Nov 8, 2022

@claudiu-cristea Thank you for getting back to us. I made a fresh release with this change included: https://github.com/sweetrdf/easyrdf/releases/tag/1.7.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Why not keeping easyrdf/easyrdf as package name?
2 participants