Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Formulate more clearly #1442

Merged
merged 1 commit into from
Nov 9, 2023
Merged

Conversation

cknuepfer
Copy link
Contributor

A sentence was formulated more precisely.

The formulation "Next, we will assign a file name to the variable filename..." is misleading for two reasons:

  1. The assignment to $filename happens before the first step inside the loop.
  2. The assignment is not done by us, the users, but by the shell interpreter.

The formulation "Next, we will assign a file name to the variable filename..." is misleading for two reasons:

1. The assignment to $filename happens before the first step inside the loop.
2. The assignment is not done by us, the users, but by the shell interpreter.
Copy link

github-actions bot commented Nov 9, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1442

The following changes were observed in the rendered markdown documents:

 05-loop.md | 3 +--
 md5sum.txt | 2 +-
 2 files changed, 2 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-11-09 07:51:16 +0000

github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
@gcapes gcapes merged commit 9d394c4 into swcarpentry:main Nov 9, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
Auto-generated via {sandpaper}
Source  : 9d394c4
Branch  : main
Author  : Gerard Capes <gerard.capes@manchester.ac.uk>
Time    : 2023-11-09 08:31:17 +0000
Message : Merge pull request #1442 from cknuepfer/cknuepfer-patch-1

Formulate more clearly
github-actions bot pushed a commit that referenced this pull request Nov 9, 2023
Auto-generated via {sandpaper}
Source  : a20693c
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-11-09 08:32:40 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 9d394c4
Branch  : main
Author  : Gerard Capes <gerard.capes@manchester.ac.uk>
Time    : 2023-11-09 08:31:17 +0000
Message : Merge pull request #1442 from cknuepfer/cknuepfer-patch-1

Formulate more clearly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants