Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update remove-unneeded-files sol'n 4 in lesson 4 (issue #1415) #1416

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

sdrobert
Copy link
Contributor

This PR is follows up issue #1415.

In the removing-unneeded-files question of lesson 4, the description of the 4th solution

The shell would expand `*.*` to match all files with any extension, so this command would delete all files

has been replaced with

The shell expands `*.*` to match all filenames containing at least one `.`, including the processed files (`.txt`) *and* raw files (`.dat`)

Note that the replacement text is slightly different from that suggested in #1415. I can easily use that text if the maintainers would prefer.

Best,
Sean

Updates sol'n 4 text in sec 4, removing-unneeded-files
@github-actions
Copy link

github-actions bot commented Jul 18, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/shell-novice/compare/md-outputs..md-outputs-PR-1416

The following changes were observed in the rendered markdown documents:

 04-pipefilter.md | 4 ++--
 md5sum.txt       | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-19 07:20:15 +0000

@sdrobert sdrobert changed the title Update 04-pipefilter.md Update remove-unneeded-files sol'n 4 in lesson 4 (issue #1415) Jul 18, 2023
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
@gcapes gcapes merged commit 8674c49 into swcarpentry:main Jul 19, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
Auto-generated via {sandpaper}
Source  : 8674c49
Branch  : main
Author  : Gerard Capes <gerard.capes@manchester.ac.uk>
Time    : 2023-07-19 07:25:07 +0000
Message : Merge pull request #1416 from sdrobert/issue-1415

Update remove-unneeded-files sol'n 4 in lesson 4

Fix #1415
github-actions bot pushed a commit that referenced this pull request Jul 19, 2023
Auto-generated via {sandpaper}
Source  : 2f4b5e3
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-19 07:26:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 8674c49
Branch  : main
Author  : Gerard Capes <gerard.capes@manchester.ac.uk>
Time    : 2023-07-19 07:25:07 +0000
Message : Merge pull request #1416 from sdrobert/issue-1415

Update remove-unneeded-files sol'n 4 in lesson 4

Fix #1415
@sdrobert sdrobert deleted the issue-1415 branch July 19, 2023 15:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants