Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

convert divs into table #678

Merged
merged 1 commit into from
Apr 15, 2024
Merged

convert divs into table #678

merged 1 commit into from
Apr 15, 2024

Conversation

alee
Copy link
Member

@alee alee commented Apr 13, 2024

cherry picking work from @martinosorb in #677

Context from that PR:

This is apparently needed for the lesson to be workable with Crowdin for internationalisation purposes (see this thread on Slack).

Please note that I can't, at the moment, check whether the version in this PR will actually work in Crowdin -- but the problem there is supposed to be about the use of <div>.

What the PR does is to change the section on Markdown of the first episode to look like this:
image

Also fixes a typo by which the level-2 header looked the same as the level-1 header.

Copy link

github-actions bot commented Apr 13, 2024

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-678

The following changes were observed in the rendered markdown documents:

 01-run-quit.md | 211 ++++++++++++++++-----------------------------------------
 md5sum.txt     |   2 +-
 2 files changed, 58 insertions(+), 155 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2024-04-13 21:52:11 +0000

github-actions bot pushed a commit that referenced this pull request Apr 13, 2024
@alee alee merged commit f52a5f1 into swcarpentry:main Apr 15, 2024
3 checks passed
@alee alee deleted the remove-div branch April 15, 2024 18:33
github-actions bot pushed a commit that referenced this pull request Apr 15, 2024
Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request Apr 15, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request Apr 16, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request Apr 23, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request Apr 30, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request May 7, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request May 14, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request May 21, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request May 28, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request Jun 4, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
github-actions bot pushed a commit that referenced this pull request Jun 11, 2024
Auto-generated via {sandpaper}
Source  : 383e596
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2024-04-15 18:34:50 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : f52a5f1
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2024-04-15 18:33:40 +0000
Message : Merge pull request #678 from alee/remove-div

convert divs into table
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants