Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

link to dedicated installation instructions page in workshop template #657

Merged
merged 1 commit into from
Jul 26, 2023

Conversation

tobyhodges
Copy link
Member

To reduce confusion for learners visiting the installation instructions, this links to a dedicated page of installation instructions in the template workshop website. This is instead of the template landing page, which contains a lot of FIXMEs that can be alarming and give someone the impression that the link has taken them to the wrong place.

@github-actions
Copy link

github-actions bot commented Jul 26, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-657

The following changes were observed in the rendered markdown documents:

 md5sum.txt | 2 +-
 setup.md   | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-26 07:51:51 +0000

github-actions bot pushed a commit that referenced this pull request Jul 26, 2023
@alee
Copy link
Member

alee commented Jul 26, 2023

Thanks @tobyhodges !

@alee alee merged commit cffd222 into swcarpentry:main Jul 26, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 26, 2023
Auto-generated via {sandpaper}
Source  : cffd222
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2023-07-26 07:54:15 +0000
Message : Merge pull request #657 from tobyhodges/link-to-install-instructions

link to dedicated installation instructions page in workshop template
github-actions bot pushed a commit that referenced this pull request Jul 26, 2023
Auto-generated via {sandpaper}
Source  : 4ed08af
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-26 07:55:38 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : cffd222
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2023-07-26 07:54:15 +0000
Message : Merge pull request #657 from tobyhodges/link-to-install-instructions

link to dedicated installation instructions page in workshop template
github-actions bot pushed a commit that referenced this pull request Jul 29, 2023
Auto-generated via {sandpaper}
Source  : 4ed08af
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-26 07:55:38 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : cffd222
Branch  : main
Author  : Allen Lee <alee@users.noreply.github.com>
Time    : 2023-07-26 07:54:15 +0000
Message : Merge pull request #657 from tobyhodges/link-to-install-instructions

link to dedicated installation instructions page in workshop template
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants