Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

628 explicit df names #654

Merged
merged 3 commits into from
Jul 24, 2023
Merged

Conversation

sjvrijn
Copy link
Contributor

@sjvrijn sjvrijn commented Jul 6, 2023

Fix #628

Episode 8:

  • Renamed df to europe

Episode 16:

  • Renamed df to asia for the first specific case
  • Renamed df to countries in the function writing exercise, since the generic continent is already used

@github-actions
Copy link

github-actions bot commented Jul 6, 2023

Thank you!

Thank you for your pull request 😃

🤖 This automated message can help you check the rendered files in your submission for clarity. If you have any questions, please feel free to open an issue in {sandpaper}.

If you have files that automatically render output (e.g. R Markdown), then you should check for the following:

  • 🎯 correct output
  • 🖼️ correct figures
  • ❓ new warnings
  • ‼️ new errors

Rendered Changes

🔍 Inspect the changes: https://github.com/swcarpentry/python-novice-gapminder/compare/md-outputs..md-outputs-PR-654

The following changes were observed in the rendered markdown documents:

 08-data-frames.md       |  8 ++++----
 16-writing-functions.md | 14 +++++++-------
 md5sum.txt              |  4 ++--
 3 files changed, 13 insertions(+), 13 deletions(-)
What does this mean?

If you have source files that require output and figures to be generated (e.g. R Markdown), then it is important to make sure the generated figures and output are reproducible.

This output provides a way for you to inspect the output in a diff-friendly manner so that it's easy to see the changes that occur due to new software versions or randomisation.

⏱️ Updated at 2023-07-24 18:17:26 +0000

@martinosorb
Copy link
Contributor

Hi @sjvrijn, thanks for the PR. It looks good, but I have a comment: episode 07 uses data_oceania instead. I suggest we use data_europe etc. (or change the other one to oceania, but I like the first option better, personally).

@sjvrijn
Copy link
Contributor Author

sjvrijn commented Jul 24, 2023

@martinosorb good point for consistency, I've updated my changes.

github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
@martinosorb
Copy link
Contributor

LGTM. Merging!

@martinosorb martinosorb merged commit 3cd6c1d into swcarpentry:main Jul 24, 2023
3 checks passed
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
Auto-generated via {sandpaper}
Source  : 3cd6c1d
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2023-07-24 18:19:40 +0000
Message : Merge pull request #654 from sjvrijn/628-explicit-df-names

628 explicit df names
github-actions bot pushed a commit that referenced this pull request Jul 24, 2023
Auto-generated via {sandpaper}
Source  : 8be466c
Branch  : md-outputs
Author  : GitHub Actions <actions@github.com>
Time    : 2023-07-24 18:20:51 +0000
Message : markdown source builds

Auto-generated via {sandpaper}
Source  : 3cd6c1d
Branch  : main
Author  : Martino Sorbaro <martinosorb@users.noreply.github.com>
Time    : 2023-07-24 18:19:40 +0000
Message : Merge pull request #654 from sjvrijn/628-explicit-df-names

628 explicit df names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

improve data frame names in the lesson
2 participants