Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain basic fork-edit-PR cycle in browser #338

Closed
gvwilson opened this issue Aug 29, 2016 · 2 comments
Closed

Explain basic fork-edit-PR cycle in browser #338

gvwilson opened this issue Aug 29, 2016 · 2 comments
Labels
intermediate status:out of scope Proposed changes are out of scope type:enhancement Propose enhancement to the lesson

Comments

@gvwilson
Copy link
Contributor

Lots of newcomers will want to fork-edit-PR through the browser, so we should have a section (or separate stream?) explaining that cycle.
@vasudevanv
Copy link

How much depth are you looking to get into? I have some material that covers
Fork -> Create branch -> Edit -> Submit PR -> Sync master with upstream (this needs a local copy command line). I can submit a PR if you like this depth.

@iglpdc iglpdc added help wanted Looking for Contributors type:enhancement Propose enhancement to the lesson and removed enhancement labels Mar 22, 2018
fmichonneau pushed a commit to fmichonneau/git-novice that referenced this issue May 28, 2019
@rgaiacs
Merge pull request swcarpentry#338 from rgaiacs/336
445392e 
Fix lesson_initialize.py to initialize new lessons
@kekoziar kekoziar added intermediate status:out of scope Proposed changes are out of scope and removed help wanted Looking for Contributors intermediate labels Jul 4, 2019
@kekoziar
Copy link
Contributor

kekoziar commented Jul 4, 2019

I suspect this is out of scope for the lesson. When upstream is added, it's definitely at intermediate level and so out of scope for a novice lesson, imo.

Also, since there has been no action on this for several years, I am going to re-add intermediate label, then close the issue. If/when a second advanced git lesson is created, the developers can use the intermediate and out of scope labels to identify content that should be taught.

@kekoziar kekoziar closed this as completed Jul 4, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
intermediate status:out of scope Proposed changes are out of scope type:enhancement Propose enhancement to the lesson
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@gvwilson @iglpdc @vasudevanv @kekoziar