Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Compress foo ? num : 0 into num * !!foo #9908

Merged
merged 1 commit into from
Jan 21, 2025
Merged

feat(es/minifier): Compress foo ? num : 0 into num * !!foo #9908

merged 1 commit into from
Jan 21, 2025
+352 −303

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Jan 21, 2025 •
edited by kdy1
Loading

Related issue:

@Austaras Austaras requested a review from a team as a code owner January 21, 2025 07:40
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 21, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: a462a19

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 reviewed Jan 21, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea, again!

crates/swc_ecma_minifier/src/compress/pure/conds.rs Outdated Show resolved Hide resolved
@kdy1 kdy1 added this to the Planned milestone Jan 21, 2025
kdy1
kdy1 approved these changes Jan 21, 2025
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I think this is fine, but just to be more confident I left a question about this on twitter. https://x.com/kdy1dev/status/1881628115430146348

@kdy1 kdy1 merged commit ce22557 into swc-project:main Jan 21, 2025
168 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.10.9 Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.10.9
Development

Successfully merging this pull request may close these issues.

Optimize: a ? 0 : 1 into +!a
2 participants
@Austaras @kdy1