Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Fix span of EOF errors #9378

Merged
merged 4 commits into from
Aug 5, 2024
Merged

fix(es/parser): Fix span of EOF errors #9378

merged 4 commits into from
Aug 5, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Aug 5, 2024

@kdy1 kdy1 added this to the Planned milestone Aug 5, 2024
@kdy1 kdy1 self-assigned this Aug 5, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 5, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 84f12e7

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@kdy1 kdy1 marked this pull request as ready for review August 5, 2024 08:10
@kdy1 kdy1 requested a review from a team as a code owner August 5, 2024 08:10
@kdy1 kdy1 requested a review from a team as a code owner August 5, 2024 08:10
kodiakhq[bot]
kodiakhq bot previously approved these changes Aug 5, 2024
View reviewed changes
@kdy1 kdy1 mentioned this pull request Aug 5, 2024
Merged
@kdy1 kdy1 enabled auto-merge (squash) August 5, 2024 08:21
@kdy1 kdy1 merged commit f702657 into swc-project:main Aug 5, 2024
154 checks passed
@kdy1 kdy1 deleted the mdxjs branch August 5, 2024 08:52
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Aug 5, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9378 will improve performances by 3.92%

Comparing kdy1:mdxjs (00100b0) with main (badd6a9)

Summary

⚡ 3 improvements
✅ 175 untouched benchmarks

Benchmarks breakdown

Benchmark main kdy1:mdxjs Change
⚡ es/full/bugs-1 561 µs 542.3 µs +3.45%
⚡ common/allocator/alloc/cached-no-scope/1000000 114.2 ms 110.3 ms +3.56%
⚡ es/visitor/base-perf/boxing_boxed_clone 2.3 µs 2.2 µs +3.92%

@kdy1 kdy1 modified the milestones: Planned, 1.7.7 Aug 5, 2024
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@swc-project swc-project locked as resolved and limited conversation to collaborators Sep 5, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
1.7.7
Development

Successfully merging this pull request may close these issues.
1 participant
@kdy1