Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix exponentiate operator #9251

Merged
merged 6 commits into from
Jul 16, 2024
Merged

fix(es/minifier): Fix exponentiate operator #9251

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5abc827
fix(es/minifier): Fix exponentiate operator
magic-akari Jul 15, 2024
a52a932
chore: update test cases
magic-akari Jul 15, 2024
7822b3f
fix
magic-akari Jul 15, 2024
adbeb7b
chore: Add as_int32 and as_uint32 methods to JsNumber
magic-akari Jul 16, 2024
6db8424
fix
magic-akari Jul 16, 2024
4d69794
Merge branch 'main' into fix/issue-9250
swc-bot Jul 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 5 additions & 10 deletions crates/swc_ecma_minifier/src/compress/util/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ use swc_common::{util::take::Take, DUMMY_SP};
use swc_ecma_ast::*;
#[cfg(feature = "debug")]
use swc_ecma_transforms_base::fixer::fixer;
use swc_ecma_utils::{ExprCtx, ExprExt, IdentUsageFinder, Value};
use swc_ecma_utils::{number::JsNumber, ExprCtx, ExprExt, IdentUsageFinder, Value};
#[cfg(feature = "debug")]
use swc_ecma_visit::{as_folder, FoldWith};
use swc_ecma_visit::{
Expand Down Expand Up @@ -512,16 +512,11 @@ pub(crate) fn eval_as_number(expr_ctx: &ExprCtx, e: &Expr) -> Option<f64> {
if args.len() != 2 {
return None;
}
let base = eval_as_number(expr_ctx, &args[0].expr)?;
let exponent = eval_as_number(expr_ctx, &args[1].expr)?;
let base: JsNumber = eval_as_number(expr_ctx, &args[0].expr)?.into();
let exponent: JsNumber =
eval_as_number(expr_ctx, &args[1].expr)?.into();

// https://tc39.es/ecma262/multipage/ecmascript-data-types-and-values.html#sec-numeric-types-number-exponentiate
// https://github.com/rust-lang/rust/issues/60468
if exponent.is_nan() {
return Some(f64::NAN);
}

return Some(base.powf(exponent));
return Some(base.pow(exponent).into());
}

_ => {}
Expand Down
1 change: 1 addition & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_nan/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
console.log(Math.pow(1, NaN));
console.log(1 ** NaN);
1 change: 1 addition & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_nan/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
console.log(NaN);
console.log(NaN);
1 change: 1 addition & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_nan/output.mangleOnly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1,2 @@
console.log(Math.pow(1, NaN));
console.log(1 ** NaN);
82 changes: 82 additions & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_spec/expected.stdout
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,85 @@ NaN
Infinity
-Infinity
1
----
NaN
NaN
NaN
NaN
1
NaN
NaN
NaN
1
NaN
Infinity
Infinity
Infinity
1
Infinity
0
0
1
NaN
Infinity
4
2
1
1.4142135623730951
0
0.5
1
NaN
NaN
1
1
1
1
NaN
1
1
NaN
0
0.25
0.5
1
0.7071067811865476
Infinity
2
1
NaN
0
0
0
1
0
Infinity
Infinity
1
NaN
Infinity
Infinity
-Infinity
1
Infinity
0
-0
1
NaN
NaN
1
-1
1
NaN
NaN
-1
1
NaN
0
0
-0
1
0
Infinity
-Infinity
1
84 changes: 84 additions & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_spec/input.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,87 @@ console.log(Math.pow(-0, 0.5));
console.log(Math.pow(-0, -Infinity));
console.log(Math.pow(-0, -1));
console.log(Math.pow(-0, -0));

console.log("----");

console.log(NaN ** NaN);
console.log(NaN ** Infinity);
console.log(NaN ** 2);
console.log(NaN ** 1);
console.log(NaN ** 0);
console.log(NaN ** 0.5);
console.log(NaN ** -Infinity);
console.log(NaN ** -1);
console.log(NaN ** -0);
console.log(Infinity ** NaN);
console.log(Infinity ** Infinity);
console.log(Infinity ** 2);
console.log(Infinity ** 1);
console.log(Infinity ** 0);
console.log(Infinity ** 0.5);
console.log(Infinity ** -Infinity);
console.log(Infinity ** -1);
console.log(Infinity ** -0);
console.log(2 ** NaN);
console.log(2 ** Infinity);
console.log(2 ** 2);
console.log(2 ** 1);
console.log(2 ** 0);
console.log(2 ** 0.5);
console.log(2 ** -Infinity);
console.log(2 ** -1);
console.log(2 ** -0);
console.log(1 ** NaN);
console.log(1 ** Infinity);
console.log(1 ** 2);
console.log(1 ** 1);
console.log(1 ** 0);
console.log(1 ** 0.5);
console.log(1 ** -Infinity);
console.log(1 ** -1);
console.log(1 ** -0);
console.log(0.5 ** NaN);
console.log(0.5 ** Infinity);
console.log(0.5 ** 2);
console.log(0.5 ** 1);
console.log(0.5 ** 0);
console.log(0.5 ** 0.5);
console.log(0.5 ** -Infinity);
console.log(0.5 ** -1);
console.log(0.5 ** -0);
console.log(0 ** NaN);
console.log(0 ** Infinity);
console.log(0 ** 2);
console.log(0 ** 1);
console.log(0 ** 0);
console.log(0 ** 0.5);
console.log(0 ** -Infinity);
console.log(0 ** -1);
console.log(0 ** -0);
console.log((-Infinity) ** NaN);
console.log((-Infinity) ** Infinity);
console.log((-Infinity) ** 2);
console.log((-Infinity) ** 1);
console.log((-Infinity) ** 0);
console.log((-Infinity) ** 0.5);
console.log((-Infinity) ** -Infinity);
console.log((-Infinity) ** -1);
console.log((-Infinity) ** -0);
console.log((-1) ** NaN);
console.log((-1) ** Infinity);
console.log((-1) ** 2);
console.log((-1) ** 1);
console.log((-1) ** 0);
console.log((-1) ** 0.5);
console.log((-1) ** -Infinity);
console.log((-1) ** -1);
console.log((-1) ** -0);
console.log((-0) ** NaN);
console.log((-0) ** Infinity);
console.log((-0) ** 2);
console.log((-0) ** 1);
console.log((-0) ** 0);
console.log((-0) ** 0.5);
console.log((-0) ** -Infinity);
console.log((-0) ** -1);
console.log((-0) ** -0);
82 changes: 82 additions & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_spec/output.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,85 @@ console.log(0);
console.log(Math.pow(-0, -1 / 0));
console.log(-Infinity);
console.log(1);
console.log("----");
console.log(NaN);
console.log(NaN);
console.log(NaN);
console.log(NaN);
console.log(1);
console.log(NaN);
console.log(NaN);
console.log(NaN);
console.log(1);
console.log(NaN);
console.log(Infinity);
console.log(Infinity);
console.log(Infinity);
console.log(1);
console.log(Infinity);
console.log(0);
console.log(0);
console.log(1);
console.log(NaN);
console.log(Infinity);
console.log(4);
console.log(2);
console.log(1);
console.log(1.4142135623730951);
console.log(0);
console.log(0.5);
console.log(1);
console.log(NaN);
console.log(NaN);
console.log(1);
console.log(1);
console.log(1);
console.log(1);
console.log(NaN);
console.log(1);
console.log(1);
console.log(NaN);
console.log(0);
console.log(0.25);
console.log(0.5);
console.log(1);
console.log(0.7071067811865476);
console.log(Infinity);
console.log(2);
console.log(1);
console.log(NaN);
console.log(0);
console.log(0);
console.log(0);
console.log(1);
console.log(0);
console.log(Infinity);
console.log(Infinity);
console.log(1);
console.log(NaN);
console.log(Infinity);
console.log(Infinity);
console.log(-Infinity);
console.log(1);
console.log(Infinity);
console.log(0);
console.log(-0);
console.log(1);
console.log(NaN);
console.log(NaN);
console.log(1);
console.log(-1);
console.log(1);
console.log(NaN);
console.log(NaN);
console.log(-1);
console.log(1);
console.log(NaN);
console.log(0);
console.log(0);
console.log(-0);
console.log(1);
console.log(0);
console.log(Infinity);
console.log(-Infinity);
console.log(1);
82 changes: 82 additions & 0 deletions crates/swc_ecma_minifier/tests/terser/compress/evaluate/pow_spec/output.mangleOnly.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,3 +79,85 @@ console.log(Math.pow(-0, 0.5));
console.log(Math.pow(-0, -Infinity));
console.log(Math.pow(-0, -1));
console.log(Math.pow(-0, -0));
console.log("----");
console.log(NaN ** NaN);
console.log(NaN ** Infinity);
console.log(NaN ** 2);
console.log(NaN ** 1);
console.log(NaN ** 0);
console.log(NaN ** 0.5);
console.log(NaN ** -Infinity);
console.log(NaN ** -1);
console.log(NaN ** -0);
console.log(Infinity ** NaN);
console.log(Infinity ** Infinity);
console.log(Infinity ** 2);
console.log(Infinity ** 1);
console.log(Infinity ** 0);
console.log(Infinity ** 0.5);
console.log(Infinity ** -Infinity);
console.log(Infinity ** -1);
console.log(Infinity ** -0);
console.log(2 ** NaN);
console.log(2 ** Infinity);
console.log(2 ** 2);
console.log(2 ** 1);
console.log(2 ** 0);
console.log(2 ** 0.5);
console.log(2 ** -Infinity);
console.log(2 ** -1);
console.log(2 ** -0);
console.log(1 ** NaN);
console.log(1 ** Infinity);
console.log(1 ** 2);
console.log(1 ** 1);
console.log(1 ** 0);
console.log(1 ** 0.5);
console.log(1 ** -Infinity);
console.log(1 ** -1);
console.log(1 ** -0);
console.log(0.5 ** NaN);
console.log(0.5 ** Infinity);
console.log(0.5 ** 2);
console.log(0.5 ** 1);
console.log(0.5 ** 0);
console.log(0.5 ** 0.5);
console.log(0.5 ** -Infinity);
console.log(0.5 ** -1);
console.log(0.5 ** -0);
console.log(0 ** NaN);
console.log(0 ** Infinity);
console.log(0 ** 2);
console.log(0 ** 1);
console.log(0 ** 0);
console.log(0 ** 0.5);
console.log(0 ** -Infinity);
console.log(0 ** -1);
console.log(0 ** -0);
console.log((-Infinity) ** NaN);
console.log((-Infinity) ** Infinity);
console.log((-Infinity) ** 2);
console.log((-Infinity) ** 1);
console.log((-Infinity) ** 0);
console.log((-Infinity) ** 0.5);
console.log((-Infinity) ** -Infinity);
console.log((-Infinity) ** -1);
console.log((-Infinity) ** -0);
console.log((-1) ** NaN);
console.log((-1) ** Infinity);
console.log((-1) ** 2);
console.log((-1) ** 1);
console.log((-1) ** 0);
console.log((-1) ** 0.5);
console.log((-1) ** -Infinity);
console.log((-1) ** -1);
console.log((-1) ** -0);
console.log((-0) ** NaN);
console.log((-0) ** Infinity);
console.log((-0) ** 2);
console.log((-0) ** 1);
console.log((-0) ** 0);
console.log((-0) ** 0.5);
console.log((-0) ** -Infinity);
console.log((-0) ** -1);
console.log((-0) ** -0);
Loading
Loading