Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(bindings): Invert Wasm size shrink #9224

Merged
merged 2 commits into from
Jul 12, 2024
Merged

perf(bindings): Invert Wasm size shrink #9224

merged 2 commits into from
Jul 12, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 12, 2024 •
edited
Loading

Reverts #9191

I'm reverting because it applies even to @swc/core. cc @magic-akari
Instead, I used an environment variable.

@kdy1 kdy1 added this to the Planned milestone Jul 12, 2024
@kdy1 kdy1 self-assigned this Jul 12, 2024
kdy1
kdy1 commented Jul 12, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 changed the title perf(bindings): Revert Wasm size shrink perf(bindings): Invert Wasm size shrink Jul 12, 2024
@kdy1 kdy1 marked this pull request as ready for review July 12, 2024 16:33
@kdy1 kdy1 requested a review from a team as a code owner July 12, 2024 16:33
@kdy1 kdy1 requested a review from magic-akari July 12, 2024 16:33
@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 12, 2024 •
edited
Loading

CodSpeed Performance Report

Merging #9224 will not alter performance

Comparing revert-9191-wasm (9a10858) with main (a7c82bd)

Summary

✅ 173 untouched benchmarks

@kdy1 kdy1 merged commit aa7f791 into main Jul 12, 2024
152 of 153 checks passed
@kdy1 kdy1 deleted the revert-9191-wasm branch July 12, 2024 20:19
@Boshen
Copy link
Contributor

Boshen commented Jul 13, 2024 •
edited
Loading

In oxc root Cargo.toml:

[profile.release.package.oxc_wasm]
opt-level = 'z'

@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@magic-akari magic-akari magic-akari approved these changes

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@kdy1 @Boshen @magic-akari