Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/modules): Fix lint issue #9206

Merged
merged 1 commit into from
Jul 11, 2024
Merged

fix(es/modules): Fix lint issue #9206

merged 1 commit into from
Jul 11, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jul 11, 2024

@kdy1 kdy1 added this to the Planned milestone Jul 11, 2024
@kdy1 kdy1 self-assigned this Jul 11, 2024
@kdy1 kdy1 requested a review from a team as a code owner July 11, 2024 10:44
@kdy1 kdy1 enabled auto-merge (squash) July 11, 2024 10:44
kdy1
kdy1 commented Jul 11, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_module

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 11, 2024

CodSpeed Performance Report

Merging #9206 will degrade performances by 41.16%

Comparing kdy1:issue-9182 (f0ef4ca) with main (7d9364c)

Summary

❌ 2 regressions
✅ 172 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main kdy1:issue-9182 Change
❌ es/full/bugs-1 575.5 µs 622.9 µs -7.6%
❌ es/full/base/resolver_and_hygiene 329 µs 559.1 µs -41.16%

@kdy1 kdy1 disabled auto-merge July 11, 2024 13:56
@kdy1 kdy1 merged commit efb8636 into swc-project:main Jul 11, 2024
151 of 152 checks passed
@kdy1 kdy1 deleted the issue-9182 branch July 11, 2024 13:57
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Open
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.

Cannot build swc, due using #![deny(unused)] lint
1 participant
@kdy1