feat(es/decorators): Implement decorator version 2023-11
#8970
Conversation
|
kdy1
changed the title
2023-11
| pub use self::{ | ||
| decorators::decorators, export_default_from::export_default_from, | ||
| import_assertions::import_assertions, | ||
| }; | ||
|
|
||
| #[derive(Debug, Default, Clone, Copy, Serialize, Deserialize)] | ||
| #[serde(deny_unknown_fields, rename_all = "camelCase")] | ||
| pub enum DecoratorVersion { |
There was a problem hiding this comment.
Babel 8 keeps only the newest and the oldest versions; I think we should also keep just two versions.
Keeping the latest version is sensible, but another that leverages TypeScript's legacy decorators (experimentalDecorators) is preferable.
It is necessary to specify the exact version. SWC references the TypeScript version with the date 2021-12, whereas Babel uses 2018-09.
The TypeScript documentation states that it adopts a Stage 2 version, but it doesn't specify the exact year and month of the draft.
There was a problem hiding this comment.
But some users will complain that removal of implementations is a breaking change, and I'm not sure if it's fine to remove an option.
There was a problem hiding this comment.
Please only remove an option in a major version 😂
kdy1
force-pushed
the
deco
branch
2 times, most recently
from
94bca5f
to
f9c0fa9
Compare
**Description:** I extracted some changes from #8970
kdy1
force-pushed
the
deco
branch
2 times, most recently
from
0fce2ca
to
6614ae8
Compare
CodSpeed Performance ReportMerging #8970 will not alter performanceComparing Summary
|
kdy1
force-pushed
the
deco
branch
2 times, most recently
from
abc7888
to
92a3c11
Compare
|
Closing in favor of #9488 |
Description:
https://github.com/babel/babel/blob/440fe413330f19fdb2c5fa63ffab87e67383d12d/packages/babel-helper-create-class-features-plugin/src/decorators.ts
Related issue:
addInitializerincorrectly throws if decorator throws #9078hasmethod on decorators context #9079