Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Respect module: false #8925

Merged
merged 11 commits into from
May 7, 2024
Merged

fix(es/minifier): Respect module: false #8925

merged 11 commits into from
May 7, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 7, 2024

Description:

Tests are modified because I enabled script detection for fixture test suite

Related issue:

@kdy1 kdy1 added this to the Planned milestone May 7, 2024
@kdy1 kdy1 self-assigned this May 7, 2024
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 7, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 501654b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 commented May 7, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier --breaking

@kdy1 kdy1 marked this pull request as ready for review May 7, 2024 02:06
@kdy1 kdy1 requested a review from a team as a code owner May 7, 2024 02:06
@kdy1 kdy1 enabled auto-merge (squash) May 7, 2024 02:07
@kdy1 kdy1 disabled auto-merge May 7, 2024 03:15
@kdy1 kdy1 merged commit aca6a77 into swc-project:main May 7, 2024
147 checks passed
@kdy1 kdy1 deleted the issue-8909 branch May 7, 2024 03:15
@kdy1 kdy1 mentioned this pull request May 7, 2024
Merged
@kdy1 kdy1 modified the milestones: Planned, v1.5.5 May 8, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jun 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq kodiakhq approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.5.5
Development

Successfully merging this pull request may close these issues.

Minifier removes function wrapper causing variables to become globals since 1.3.71
1 participant
@kdy1