-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/utils): Preserve optional chain effect #8850
Conversation
|
@@ -2520,11 +2520,6 @@ impl ExprCtx { | |||
to.push(Box::new(Expr::New(e))) | |||
} | |||
Expr::Member(_) | Expr::SuperProp(_) => to.push(Box::new(expr)), | |||
Expr::OptChain(OptChainExpr { ref base, .. }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is obviously wrong -- hasn't considered computed keys, and I'm worried about nested case too, so it's economical to just remove it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_core
- swc_ecma_utils
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Automated review comment generated by auto-rebase script
Description:
BREAKING CHANGE:
Related issue (if exists):
Closes #8844