fix(es): Fix default value of jsc.minify.format.comments
#7853
+5,565
−1,093
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
kdy1
pushed a commit
that referenced
this pull request
Aug 27, 2023
**Description:** Looks like the bug I ran into had nothing to do with the changes in #7856, since it's reproducible without it. Looks like it might have only surfaced now because #7853 changed the default value of `jsc.minify.format.comments`? Added a minimal test case here with the expected result. Here's the actual output: ```js export var padding = ''; export function exec2({ commands }) { return __awaiter(this, void 0, void 0, function*() { for(let i2 = 0; i2 < commands.length; i2++){ let command = commands[i2]; yield // some-comment function({ command }) { command(); }({ command, handleError }); } }); } ``` The comment ends up getting added after the yield, which makes the output invalid. Going to see if I can figure out a fix tomorrow, but let me know if you have any ideas on where to start looking in the meantime!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Related issue: