Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Only cast global Infinity/undefined/NaN #7684

Merged
merged 1 commit into from
Jul 21, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

console.log(Infinity);
if (Infinity > 4) console.log("Infinity");
}{
let NaN1 = 3;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is something wrong with resolver.
It has nothing to do with this fix.

@magic-akari magic-akari marked this pull request as ready for review July 20, 2023 15:29
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_utils

@kdy1 kdy1 enabled auto-merge (squash) July 20, 2023 22:47
@kdy1 kdy1 merged commit 241c04a into swc-project:main Jul 21, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.71 Jul 25, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 24, 2023
@magic-akari magic-akari deleted the fix/issue-7683 branch September 18, 2023 08:48
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Wrong dead code elimination with variable named Infinity
2 participants