Fixing the Wasm blocker for Parser - try 2 #495
Conversation
|
bors r+ |
|
🔒 Permission denied Existing reviewers: click here to make anurbol a reviewer |
|
It's great enough. Note that parser is special in swc, as it should be usable from stable rust, and as an ecmascript parser. Some rust projects uses it already. |
|
@kdy1 that's good to hear! I suspected that this should be the case, because the parser alone seems to be of incredible usefulness! BTW thank you for actively responding and giving feedback 😃 |
|
Can you run cargo fmt --all? |
|
I think the rustfmt error is related to alphabetical sorting. |
|
Yep, it was the case. Now fixed. Do you by any chance know, is there an easier way in such situations than creating a new pull request every time? |
|
Pushing a new commit to the pr branch would update the pr. |
|
@anurbol Thank you for the pr!! I merged it. |
|
Great!!! Thanks for merging, Dong Yoon (I hope it's correct)! |
|
It's correct :) |
|
@kdy1 Lol, I now see https://github.com/swc-project/swc/pull/479/files#diff-b052edc95cbba2d88ad873bdb3551146 was the "culprit" :D (no blame intended) I am not sure how renaming dependencies is a "2018 feature". |
Rust has a bug when compiling a project for Wasm (with
--target wasm32-unknown-unknownflag), these changes are a workaround.These changes are only supposed to fix the SWC Parser, not the whole SWC project. This is because I only need the Parser at the moment, also fixing the whole SWC Project would be a nightmare for me, a newbie in SWC. Maybe later.