Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(common): Reserve BytePos(0) for dummy spans #4616

Merged
merged 45 commits into from
May 11, 2022
Merged

feat(common): Reserve BytePos(0) for dummy spans #4616

merged 45 commits into from
May 11, 2022
+1,091,004 −1,092,836

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented May 11, 2022 •
edited
Loading

Description:

TODOs

  • Optimize source map logic of es codegen

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone May 11, 2022
kdy1
kdy1 commented May 11, 2022
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_common --breaking

@kdy1 kdy1 marked this pull request as ready for review May 11, 2022 15:39
kodiakhq[bot]
kodiakhq bot previously approved these changes May 11, 2022
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) May 11, 2022 15:39
@kdy1 kdy1 mentioned this pull request May 11, 2022
Closed
@kdy1 kdy1 merged commit 67942d5 into swc-project:main May 11, 2022
@kdy1 kdy1 deleted the bytepos branch May 11, 2022 16:14
@kdy1 kdy1 modified the milestones: Planned, v1.2.183 May 12, 2022
@g-plane g-plane mentioned this pull request May 12, 2022
Closed
@dsherret dsherret mentioned this pull request May 12, 2022
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 21, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.2.183
Development

Successfully merging this pull request may close these issues.

First source mapping is missing
1 participant
@kdy1