fix(es/resolver): Ignore names of jsx attributes #3289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kwonoj
previously approved these changes
Jan 17, 2022
kdy1
commented
Jan 17, 2022
There was a problem hiding this comment.
@kwonoj The resolver pass was attaching the same syntax context as the parameter, so onChange in
<input
onChange={function () {
}}
/>got same syntax context as onChange in the paramter. And as es2015::function_name pass clones onChange of onChange: fuction () {} (generated by jsx pass), it resulted in a bug.
kwonoj
approved these changes
Jan 17, 2022
kodiakhq bot
pushed a commit
to vercel/next.js
that referenced
this pull request
Jan 19, 2022
This PR applies lots of patches, including - swc-project/swc#3303 - swc-project/swc#3301 - swc-project/swc#3287 - swc-project/swc#3286 - swc-project/swc#3289 - swc-project/swc#3302 - Fixes #33265 (Verified) I'll undraft this after verifying
natew
pushed a commit
to natew/next.js
that referenced
this pull request
Feb 16, 2022
This PR applies lots of patches, including - swc-project/swc#3303 - swc-project/swc#3301 - swc-project/swc#3287 - swc-project/swc#3286 - swc-project/swc#3289 - swc-project/swc#3302 - Fixes vercel#33265 (Verified) I'll undraft this after verifying
nevilm-lt
pushed a commit
to nevilm-lt/next.js
that referenced
this pull request
Apr 22, 2022
This PR applies lots of patches, including - swc-project/swc#3303 - swc-project/swc#3301 - swc-project/swc#3287 - swc-project/swc#3286 - swc-project/swc#3289 - swc-project/swc#3302 - Fixes vercel#33265 (Verified) I'll undraft this after verifying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
swc_ecma_transforms_base:
BREAKING CHANGE:
Related issue (if exists):