Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typescript commonjs default import is removed #1448

Closed
Austaras opened this issue Mar 1, 2021 · 1 comment · Fixed by #1529
Closed

Typescript commonjs default import is removed #1448

Austaras opened this issue Mar 1, 2021 · 1 comment · Fixed by #1529
Assignees
@kdy1
Labels
C-bug
Milestone
v1.2.52

Comments

@Austaras
Copy link
Member

Austaras commented Mar 1, 2021

Input code

import F = require("yaml")
console.log(F)

Describe the bug
only generate

console.log(F)

Config

{
                env: {
                    coreJs: 3
                },
                jsc: {
                    parser: {
                        syntax: 'typescript',
                        tsx: true
                    },
                    loose: true
                }
}

Expected behavior
import something from yaml
Version
The version of @swc/core: latest
@Austaras Austaras added the C-bug label Mar 1, 2021
@kdy1 kdy1 added this to the v1.2.51 milestone Mar 3, 2021
@kdy1 kdy1 modified the milestones: v1.2.51, v1.2.52 Mar 28, 2021
@kdy1 kdy1 self-assigned this Apr 1, 2021
@kdy1 kdy1 mentioned this issue Apr 1, 2021
Merged
4 tasks
kdy1 added a commit to kdy1/swc that referenced this issue Apr 1, 2021
@kdy1
Add a test for swc-project#1448
e5082dc
kdy1 added a commit to kdy1/swc that referenced this issue Apr 1, 2021
@kdy1
Add a test for swc-project#1448
a79ed66
kdy1 added a commit to kdy1/swc that referenced this issue Apr 1, 2021
@kdy1
Fix swc-project#1448
19e018f
@kdy1 kdy1 closed this as completed in #1529 Apr 2, 2021
kdy1 added a commit that referenced this issue Apr 2, 2021
@kdy1
fix(swc): Fix bugs (#1529)
252804d 
swc_ecma_parser:
 - Fix comment positions. (#1530)

swc_ecam_transforms_compat:
 - Handle default in destructuring binding patterns. (#1477, #1449)
 - `async_to_generator`: Handle `this` correctly for async function in key-value properties. (#1455)

swc_ecam_transforms_typescript:
 - Handle import defaults. (#1448)
@swc-bot
Copy link
Collaborator

swc-bot commented Oct 25, 2022

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 25, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@kdy1 kdy1

Labels
C-bug
Milestone
v1.2.52
Development

Successfully merging a pull request may close this issue.

fix(swc): Fix bugs kdy1/swc
3 participants
@Austaras @kdy1 @swc-bot