Skip to content

Commit

Permalink
doc(es/minifier): Add contributing section
Browse files Browse the repository at this point in the history
  • Loading branch information
kdy1 committed Jul 13, 2024
1 parent bb19604 commit e22f3ba
Showing 1 changed file with 16 additions and 0 deletions.
16 changes: 16 additions & 0 deletions crates/swc_ecma_minifier/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -18,3 +18,19 @@ From mac os x, run
```
./scripts/instrument/all.sh path/to/input/dir
```

# Contributing

## Testing

Please prefer execution tests over unit tests. Execution tests are more useful because there's no chance of human error while reviewing.

### Execution tests

You can add a test to [`./tests/exec.rs`](https://github.com/swc-project/swc/blob/main/crates/swc_ecma_minifier/tests/exec.rs)

You can run `./scripts/exec.sh` from `./crates/swc_ecma_minifier` to run execution tests of SWC minifier. `exec.sh` runs the cargo test with `--features debug`, and it makes the cargo test print lots of debug logging. You can search for `"change"`, and you can know the code responsible the optimization. The minifier has `report_change!` macro, and it prints the location of the relevant code.

### Fixture tests

You can add a test to [`./tests/fixture`](https://github.com/swc-project/swc/blob/main/crates/swc_ecma_minifier/tests/fixture/). You can select any directory, but please prefer to use the `issues` directory. You can run `./scripts/test.sh` from `./crates/swc_ecma_minifier` to run fixture tests. You can run it like `./scripts/test.sh foo` to run test cases only with `foo` in the file path. If you want to get location of change, you can do `./scripts/test.sh foo --features debug`.

0 comments on commit e22f3ba

Please sign in to comment.