Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(cli): Add callbacks to cli #56

Merged
merged 2 commits into from
Sep 14, 2024
Merged

feat(cli): Add callbacks to cli #56

merged 2 commits into from
Sep 14, 2024

Conversation

lake2
Copy link
Contributor

@lake2 lake2 commented Sep 13, 2024

Closes #55

I rename packages/cli/src/swc/index.ts to packages/cli/src/swc/bin.ts, and export swcDir function via new packages/cli/src/swc/index.ts

add doc here: swc-project/website#261

Copy link

changeset-bot bot commented Sep 13, 2024

⚠️ No Changeset found

Latest commit: 605a2b2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@CLAassistant
Copy link

CLAassistant commented Sep 13, 2024

CLA assistant check
All committers have signed the CLA.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add some tests for this?

@lake2
Copy link
Contributor Author

lake2 commented Sep 13, 2024

Can you add some tests for this?

I tried, I can add tests for watch=false and sync=true options.
It's hard to mock worker and file change watcher.

@kdy1
Copy link
Member

kdy1 commented Sep 13, 2024

I think tests to ensure that onSuccess and onFail are called are enough

@kdy1 kdy1 self-requested a review September 13, 2024 07:42
@lake2
Copy link
Contributor Author

lake2 commented Sep 13, 2024

I think tests to ensure that onSuccess and onFail are called are enough

Sure. I will accomplish it later.

@lake2
Copy link
Contributor Author

lake2 commented Sep 13, 2024

I think tests to ensure that onSuccess and onFail are called are enough

Test cases update. Can you release a beta version for testing?

@kdy1 kdy1 changed the title feat(cli): add callbacks to cli feat(cli): Add callbacks to cli Sep 14, 2024
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As I don't want to delete git tag or publish from a PR branch, I'll merge it first and revert/invert it as needed

@kdy1 kdy1 merged commit 4e31fd9 into swc-project:main Sep 14, 2024
11 checks passed
kdy1 pushed a commit to swc-project/website that referenced this pull request Oct 7, 2024
kdy1 added a commit that referenced this pull request Oct 22, 2024
kdy1 added a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Add callback functions to CLI
3 participants