Skip to content
This repository has been archived by the owner on Nov 1, 2021. It is now read-only.

Basic Wayland backend #17

Merged
merged 14 commits into from
Jun 20, 2017
Merged

Basic Wayland backend #17

merged 14 commits into from
Jun 20, 2017

Conversation

nyorain
Copy link
Contributor

@nyorain nyorain commented Jun 20, 2017

Implements a basic wayland backend. (Basic) ouput and backend selection work, while input handling is not yet implemented in any way. Always uses wl_shell_surface for now.

nyorain and others added 14 commits June 19, 2017 17:46
@nyorain
Start to fix wayland backend
904739c 
Starts to update the wayland backend to the new backend api.
Not yet updated to libinput branch (not yet compiling).
@nyorain
Merge branch 'libinput' into wayland-backend
41a4773
@nyorain
Continue wayland backend update
8fbf1ca 
Update wayland backend to new api.
Start to use the input interfaces.
Compiling now, not tested.
@nyorain
Fix furhter wayland backend issues
10526de
@nyorain
Merge branch 'master' into wayland-backend
e65ca96
@nyorain
Rework wayland backend output implementation
792d535
@nyorain
Adapt codestyle
e22626e
@nyorain
Make egl_error function part of the egl interface
62b1421 
The function may be useful for backends using egl.
@nyorain
Implement wayland backend output
50ce35e
@nyorain
Fix egl workaround; Test with weston
500e918
@nyorain
Merge branch 'master'
a96d90d
@nyorain
Cleanup some leaks/incorrect destructions
51f35e7
@ddevault
Clean up Wayland backend GL context and such
c9d5a0b
@ddevault
Add dynamic output resizing for Wayland backend
b9d36c8 
This allows outputs to:
- Not support modesetting
- Resize themselves
@ddevault
Copy link
Contributor

ddevault commented Jun 20, 2017 •
edited
Loading

Pushed some changes of my own - now supports resizing the outputs. Also did some cleanup. Going to add this todo list to #9:

  • Input devices
  • Multiple outputs (make wlr_wl_output_add public and check WLR_WL_OUTPUTS on init)
  • Establish generic module for wayland clients - we'll need more clients later

@ddevault ddevault merged commit 33f2c66 into swaywm:master Jun 20, 2017
@ddevault
Copy link
Contributor

Many thanks, @nyorain!

@nyorain nyorain deleted the wayland-backend branch June 24, 2017 15:36
@acrisci acrisci mentioned this pull request Jun 23, 2018
Merged
@soreau soreau mentioned this pull request Nov 6, 2018
Closed
@pelikan pelikan mentioned this pull request Sep 25, 2021
Closed
emersion added a commit to emersion/wlroots that referenced this pull request Oct 29, 2021
@emersion
output: fix stack variable lifetime in wlr_output_send_present
6dfbe34 
Variables on the stack are released when the parent block is closed.
Here, `now` is used outside of the `if` block, causing the following
crash when starting Sway with the headless backend:

    ==49606==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7fff94645f90 at pc 0x5558aeae9e29 bp 0x7fff94645df0 sp 0x7fff94645de0
    READ of size 16 at 0x7fff94645f90 thread T0
        #0 0x5558aeae9e28 in handle_present ../sway/desktop/output.c:834
        #1 0x7fdc8d6792fb in wlr_signal_emit_safe ../subprojects/wlroots/util/signal.c:29
        #2 0x7fdc8d54f77f in wlr_output_send_present ../subprojects/wlroots/types/output/output.c:766
        swaywm#3 0x7fdc8d524a28 in output_commit ../subprojects/wlroots/backend/headless/output.c:71
        swaywm#4 0x7fdc8d54d2db in wlr_output_commit ../subprojects/wlroots/types/output/output.c:629
        swaywm#5 0x5558aeb013cb in output_render ../sway/desktop/render.c:1157
        swaywm#6 0x5558aeae549e in output_repaint_timer_handler ../sway/desktop/output.c:544
        swaywm#7 0x5558aeae5f8a in damage_handle_frame ../sway/desktop/output.c:606
        swaywm#8 0x7fdc8d6792fb in wlr_signal_emit_safe ../subprojects/wlroots/util/signal.c:29
        swaywm#9 0x7fdc8d6007d5 in output_handle_frame ../subprojects/wlroots/types/wlr_output_damage.c:44
        swaywm#10 0x7fdc8d6792fb in wlr_signal_emit_safe ../subprojects/wlroots/util/signal.c:29
        swaywm#11 0x7fdc8d54ee84 in wlr_output_send_frame ../subprojects/wlroots/types/output/output.c:720
        swaywm#12 0x7fdc8d54efc3 in schedule_frame_handle_idle_timer ../subprojects/wlroots/types/output/output.c:728
        swaywm#13 0x7fdc8c9dcf5a in wl_event_loop_dispatch_idle (/usr/lib/libwayland-server.so.0+0xaf5a)
        swaywm#14 0x7fdc8c9dcfb4 in wl_event_loop_dispatch (/usr/lib/libwayland-server.so.0+0xafb4)
        swaywm#15 0x7fdc8c9dabc6 in wl_display_run (/usr/lib/libwayland-server.so.0+0x8bc6)
        swaywm#16 0x5558aeac8e30 in server_run ../sway/server.c:285
        swaywm#17 0x5558aeac3c7d in main ../sway/main.c:396
        swaywm#18 0x7fdc8be35b24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24)
        swaywm#19 0x5558aea8686d in _start (/home/simon/src/sway/build/sway/sway+0x33f86d)
vyivel pushed a commit that referenced this pull request Oct 29, 2021
@emersion
output: fix stack variable lifetime in wlr_output_send_present
b2f6ff4 
Variables on the stack are released when the parent block is closed.
Here, `now` is used outside of the `if` block, causing the following
crash when starting Sway with the headless backend:

    ==49606==ERROR: AddressSanitizer: stack-use-after-scope on address 0x7fff94645f90 at pc 0x5558aeae9e29 bp 0x7fff94645df0 sp 0x7fff94645de0
    READ of size 16 at 0x7fff94645f90 thread T0
        #0 0x5558aeae9e28 in handle_present ../sway/desktop/output.c:834
        #1 0x7fdc8d6792fb in wlr_signal_emit_safe ../subprojects/wlroots/util/signal.c:29
        #2 0x7fdc8d54f77f in wlr_output_send_present ../subprojects/wlroots/types/output/output.c:766
        #3 0x7fdc8d524a28 in output_commit ../subprojects/wlroots/backend/headless/output.c:71
        #4 0x7fdc8d54d2db in wlr_output_commit ../subprojects/wlroots/types/output/output.c:629
        #5 0x5558aeb013cb in output_render ../sway/desktop/render.c:1157
        #6 0x5558aeae549e in output_repaint_timer_handler ../sway/desktop/output.c:544
        #7 0x5558aeae5f8a in damage_handle_frame ../sway/desktop/output.c:606
        #8 0x7fdc8d6792fb in wlr_signal_emit_safe ../subprojects/wlroots/util/signal.c:29
        #9 0x7fdc8d6007d5 in output_handle_frame ../subprojects/wlroots/types/wlr_output_damage.c:44
        #10 0x7fdc8d6792fb in wlr_signal_emit_safe ../subprojects/wlroots/util/signal.c:29
        #11 0x7fdc8d54ee84 in wlr_output_send_frame ../subprojects/wlroots/types/output/output.c:720
        #12 0x7fdc8d54efc3 in schedule_frame_handle_idle_timer ../subprojects/wlroots/types/output/output.c:728
        #13 0x7fdc8c9dcf5a in wl_event_loop_dispatch_idle (/usr/lib/libwayland-server.so.0+0xaf5a)
        #14 0x7fdc8c9dcfb4 in wl_event_loop_dispatch (/usr/lib/libwayland-server.so.0+0xafb4)
        #15 0x7fdc8c9dabc6 in wl_display_run (/usr/lib/libwayland-server.so.0+0x8bc6)
        #16 0x5558aeac8e30 in server_run ../sway/server.c:285
        #17 0x5558aeac3c7d in main ../sway/main.c:396
        #18 0x7fdc8be35b24 in __libc_start_main (/usr/lib/libc.so.6+0x27b24)
        #19 0x5558aea8686d in _start (/home/simon/src/sway/build/sway/sway+0x33f86d)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nyorain @ddevault